Test that legacy code that use non-function type aliases.

Change-Id: I8b80c2eb6f2ccc9a1d523e4350a47715cde1c411
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176322
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: scheglov

pkg/analyzer/test/src/dart/resolution/type_name_test.dart

@@ -346,79 +346,130 @@ void f() {
     );
   }
 
-  test_typeAlias_asParameter_Never_none() async {
+  test_typeAlias_asParameterType_interfaceType_none() async {
     await assertNoErrorsInCode(r'''
-typedef X = Never;
-void f(X a, X? b) {}
+typedef X<T> = Map<int, T>;
+void f(X<String> a, X<String?> b) {}
 ''');
 
     assertTypeName(
-      findNode.typeName('X a'),
+      findNode.typeName('X<String>'),
       findElement.typeAlias('X'),
-      'Never',
+      'Map<int, String>',
     );
 
     assertTypeName(
-      findNode.typeName('X? b'),
+      findNode.typeName('X<String?>'),
       findElement.typeAlias('X'),
-      'Never?',
+      'Map<int, String?>',
     );
   }
 
-  test_typeAlias_asParameter_Never_question() async {
+  test_typeAlias_asParameterType_interfaceType_none_inLegacy() async {
+    newFile('$testPackageLibPath/a.dart', content: r'''
+typedef X<T> = Map<int, T>;
+''');
     await assertNoErrorsInCode(r'''
-typedef X = Never?;
-void f(X a, X? b) {}
+// @dart = 2.9
+import 'a.dart';
+void f(X<String> a) {}
 ''');
 
     assertTypeName(
-      findNode.typeName('X a'),
+      findNode.typeName('X<String>'),
+      findElement.importFind('package:test/a.dart').typeAlias('X'),
+      'Map<int*, String*>*',
+    );
+  }
+
+  test_typeAlias_asParameterType_interfaceType_question() async {
+    await assertNoErrorsInCode(r'''
+typedef X<T> = List<T?>;
+void f(X<int> a, X<int?> b) {}
+''');
+
+    assertTypeName(
+      findNode.typeName('X<int>'),
       findElement.typeAlias('X'),
-      'Never?',
+      'List<int?>',
     );
 
     assertTypeName(
-      findNode.typeName('X? b'),
+      findNode.typeName('X<int?>'),
       findElement.typeAlias('X'),
-      'Never?',
+      'List<int?>',
     );
   }
 
-  test_typeAlias_asParameterType_interfaceType_none() async {
+  test_typeAlias_asParameterType_interfaceType_question_inLegacy() async {
+    newFile('$testPackageLibPath/a.dart', content: r'''
+typedef X<T> = List<T?>;
+''');
     await assertNoErrorsInCode(r'''
-typedef X<T> = Map<int, T>;
-void f(X<String> a, X<String?> b) {}
+// @dart = 2.9
+import 'a.dart';
+void f(X<int> a) {}
 ''');
 
     assertTypeName(
-      findNode.typeName('X<String>'),
+      findNode.typeName('X<int>'),
+      findElement.importFind('package:test/a.dart').typeAlias('X'),
+      'List<int*>*',
+    );
+  }
+
+  test_typeAlias_asParameterType_Never_none() async {
+    await assertNoErrorsInCode(r'''
+typedef X = Never;
+void f(X a, X? b) {}
+''');
+
+    assertTypeName(
+      findNode.typeName('X a'),
       findElement.typeAlias('X'),
-      'Map<int, String>',
+      'Never',
     );
 
     assertTypeName(
-      findNode.typeName('X<String?>'),
+      findNode.typeName('X? b'),
       findElement.typeAlias('X'),
-      'Map<int, String?>',
+      'Never?',
     );
   }
 
-  test_typeAlias_asParameterType_interfaceType_question() async {
+  test_typeAlias_asParameterType_Never_none_inLegacy() async {
+    newFile('$testPackageLibPath/a.dart', content: r'''
+typedef X = Never;
+''');
     await assertNoErrorsInCode(r'''
-typedef X<T> = List<T?>;
-void f(X<int> a, X<int?> b) {}
+// @dart = 2.9
+import 'a.dart';
+void f(X a) {}
 ''');
 
     assertTypeName(
-      findNode.typeName('X<int>'),
+      findNode.typeName('X a'),
+      findElement.importFind('package:test/a.dart').typeAlias('X'),
+      'Null*',
+    );
+  }
+
+  test_typeAlias_asParameterType_Never_question() async {
+    await assertNoErrorsInCode(r'''
+typedef X = Never?;
+void f(X a, X? b) {}
+''');
+
+    assertTypeName(
+      findNode.typeName('X a'),
       findElement.typeAlias('X'),
-      'List<int?>',
+      'Never?',
     );
 
     assertTypeName(
-      findNode.typeName('X<int?>'),
+      findNode.typeName('X? b'),
       findElement.typeAlias('X'),
-      'List<int?>',
+      'Never?',
     );
   }
 

pkg/analyzer/test/src/summary/resynthesize_common.dart

@@ -12595,6 +12595,22 @@ void f(int a) {}
 ''');
   }
 
+  test_typedef_nonFunction_using_interface_noTypeParameters_legacy() async {
+    featureSet = FeatureSets.nonFunctionTypeAliases;
+    newFile('/a.dart', content: r'''
+typedef A = List<int>;
+''');
+    var library = await checkLibrary(r'''
+// @dart = 2.9
+import 'a.dart';
+void f(A a) {}
+''');
+    checkElementText(library, r'''
+import 'a.dart';
+void f(List<int*>* a) {}
+''');
+  }
+
   test_typedef_nonFunction_using_interface_noTypeParameters_question() async {
     featureSet = FeatureSets.nonFunctionTypeAliases;
     var library = await checkLibrary(r'''