Skip to content

Commit 4d3580a

Browse files
authored
Remove upper case constants (flutter#17)
* Remove usage of upper-case constants. * update SDK version * Remove 1.23.0 from travis config.
1 parent e05e194 commit 4d3580a

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

.travis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ language: dart
22

33
dart:
44
- dev
5-
- stable
6-
- 1.23.0
75

86
dart_task:
97
- test: --platform vm

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## 3.1.2
22

3-
* Require Dart SDK 1.23 or greater.
3+
* Require Dart SDK 2.0.0-dev.17.0 or greater.
44

55
* A number of strong-mode fixes.
66

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ homepage: https://github.com/dart-lang/http_parser
55
description: >
66
A platform-independent package for parsing and serializing HTTP formats.
77
environment:
8-
sdk: ">=1.23.0 <2.0.0"
8+
sdk: ">=2.0.0-dev.17.0 <2.0.0"
99
dependencies:
1010
charcode: "^1.1.0"
1111
collection: ">=0.9.1 <2.0.0"

test/http_date_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ void main() {
4343
test("parses the example date", () {
4444
var date = parseHttpDate("Sun, 06 Nov 1994 08:49:37 GMT");
4545
expect(date.day, equals(6));
46-
expect(date.month, equals(DateTime.NOVEMBER));
46+
expect(date.month, equals(DateTime.november));
4747
expect(date.year, equals(1994));
4848
expect(date.hour, equals(8));
4949
expect(date.minute, equals(49));
@@ -147,7 +147,7 @@ void main() {
147147
test("parses the example date", () {
148148
var date = parseHttpDate("Sunday, 06-Nov-94 08:49:37 GMT");
149149
expect(date.day, equals(6));
150-
expect(date.month, equals(DateTime.NOVEMBER));
150+
expect(date.month, equals(DateTime.november));
151151
expect(date.year, equals(1994));
152152
expect(date.hour, equals(8));
153153
expect(date.minute, equals(49));
@@ -239,7 +239,7 @@ void main() {
239239
test("parses the example date", () {
240240
var date = parseHttpDate("Sun Nov 6 08:49:37 1994");
241241
expect(date.day, equals(6));
242-
expect(date.month, equals(DateTime.NOVEMBER));
242+
expect(date.month, equals(DateTime.november));
243243
expect(date.year, equals(1994));
244244
expect(date.hour, equals(8));
245245
expect(date.minute, equals(49));
@@ -250,7 +250,7 @@ void main() {
250250
test("parses a date with a two-digit day", () {
251251
var date = parseHttpDate("Sun Nov 16 08:49:37 1994");
252252
expect(date.day, equals(16));
253-
expect(date.month, equals(DateTime.NOVEMBER));
253+
expect(date.month, equals(DateTime.november));
254254
expect(date.year, equals(1994));
255255
expect(date.hour, equals(8));
256256
expect(date.minute, equals(49));

0 commit comments

Comments
 (0)