Enable and fix standard lints, test on oldest supported SDK (flutter#20)

Author: kevmoo

.travis.yml

@@ -2,16 +2,15 @@ language: dart
 
 dart:
   - dev
-  - stable
+  - 2.0.0
 
 dart_task:
   - test: --platform vm
   - test: --platform chrome
-  - dartanalyzer
-  - dartfmt
+  - dartanalyzer: --fatal-warnings --fatal-infos .
 
 matrix:
-  exclude:
+  include:
     - dart: dev
       dart_task: dartfmt
 

analysis_options.yaml

@@ -0,0 +1,43 @@
+include: package:pedantic/analysis_options.yaml
+analyzer:
+  strong-mode:
+    implicit-casts: false
+linter:
+  rules:
+    - avoid_empty_else
+    - avoid_init_to_null
+    - avoid_null_checks_in_equality_operators
+    - avoid_unused_constructor_parameters
+    - await_only_futures
+    - camel_case_types
+    - cancel_subscriptions
+    - constant_identifier_names
+    - control_flow_in_finally
+    - directives_ordering
+    - empty_catches
+    - empty_constructor_bodies
+    - empty_statements
+    - hash_and_equals
+    - implementation_imports
+    - iterable_contains_unrelated_type
+    - library_names
+    - library_prefixes
+    - list_remove_unrelated_type
+    - non_constant_identifier_names
+    - overridden_fields
+    - package_api_docs
+    - package_names
+    - package_prefixed_library_names
+    - prefer_equal_for_default_values
+    - prefer_final_fields
+    - prefer_generic_function_type_aliases
+    - prefer_is_not_empty
+    - slash_for_doc_comments
+    - test_types_in_equals
+    - throw_in_finally
+    - type_init_formals
+    - unnecessary_brace_in_string_interps
+    - unnecessary_const
+    - unnecessary_new
+    - unrelated_type_equality_checks
+    - valid_regexps

codereview.settings

@@ -9,7 +9,7 @@ import 'dart:collection';
 /// See also [ChunkedConversionSink.withCallback].
 class AccumulatorSink<T> implements Sink<T> {
   /// An unmodifiable list of events passed to this sink so far.
-  List<T> get events => new UnmodifiableListView(_events);
+  List<T> get events => UnmodifiableListView(_events);
   final _events = <T>[];
 
   /// Whether [close] has been called.
@@ -25,7 +25,7 @@ class AccumulatorSink<T> implements Sink<T> {
 
   void add(T event) {
     if (_isClosed) {
-      throw new StateError("Can't add to a closed sink.");
+      throw StateError("Can't add to a closed sink.");
     }
 
     _events.add(event);

lib/src/accumulator_sink.dart

@@ -15,9 +15,9 @@ class ByteAccumulatorSink extends ByteConversionSinkBase {
   ///
   /// The returned [Uint8List] is viewing a shared buffer, so it should not be
   /// changed and any bytes outside the view should not be accessed.
-  Uint8List get bytes => new Uint8List.view(_buffer.buffer, 0, _buffer.length);
+  Uint8List get bytes => Uint8List.view(_buffer.buffer, 0, _buffer.length);
 
-  final _buffer = new Uint8Buffer();
+  final _buffer = Uint8Buffer();
 
   /// Whether [close] has been called.
   bool get isClosed => _isClosed;
@@ -32,15 +32,15 @@ class ByteAccumulatorSink extends ByteConversionSinkBase {
 
   void add(List<int> bytes) {
     if (_isClosed) {
-      throw new StateError("Can't add to a closed sink.");
+      throw StateError("Can't add to a closed sink.");
     }
 
     _buffer.addAll(bytes);
   }
 
   void addSlice(List<int> chunk, int start, int end, bool isLast) {
     if (_isClosed) {
-      throw new StateError("Can't add to a closed sink.");
+      throw StateError("Can't add to a closed sink.");
     }
 
     _buffer.addAll(chunk, start, end);

lib/src/byte_accumulator_sink.dart

@@ -6,14 +6,14 @@ library convert.hex;
 
 import 'dart:convert';
 
-import 'hex/encoder.dart';
 import 'hex/decoder.dart';
+import 'hex/encoder.dart';
 
-export 'hex/encoder.dart' hide hexEncoder;
 export 'hex/decoder.dart' hide hexDecoder;
+export 'hex/encoder.dart' hide hexEncoder;
 
 /// The canonical instance of [HexCodec].
-const hex = const HexCodec._();
+const hex = HexCodec._();
 
 /// A codec that converts byte arrays to and from hexadecimal strings, following
 /// [the Base16 spec][rfc].

lib/src/hex.dart

@@ -10,7 +10,7 @@ import 'dart:typed_data';
 import '../utils.dart';
 
 /// The canonical instance of [HexDecoder].
-const hexDecoder = const HexDecoder._();
+const hexDecoder = HexDecoder._();
 
 /// A converter that decodes hexadecimal strings into byte arrays.
 ///
@@ -22,17 +22,17 @@ class HexDecoder extends Converter<String, List<int>> {
 
   List<int> convert(String string) {
     if (!string.length.isEven) {
-      throw new FormatException(
+      throw FormatException(
           "Invalid input length, must be even.", string, string.length);
     }
 
-    var bytes = new Uint8List(string.length ~/ 2);
+    var bytes = Uint8List(string.length ~/ 2);
     _decode(string.codeUnits, 0, string.length, bytes, 0);
     return bytes;
   }
 
   StringConversionSink startChunkedConversion(Sink<List<int>> sink) =>
-      new _HexDecoderSink(sink);
+      _HexDecoderSink(sink);
 }
 
 /// A conversion sink for chunked hexadecimal decoding.
@@ -61,11 +61,11 @@ class _HexDecoderSink extends StringConversionSinkBase {
     Uint8List bytes;
     int bytesStart;
     if (_lastDigit == null) {
-      bytes = new Uint8List((end - start) ~/ 2);
+      bytes = Uint8List((end - start) ~/ 2);
       bytesStart = 0;
     } else {
       var hexPairs = (end - start - 1) ~/ 2;
-      bytes = new Uint8List(1 + hexPairs);
+      bytes = Uint8List(1 + hexPairs);
       bytes[0] = _lastDigit + digitForCodeUnit(codeUnits, start);
       start++;
       bytesStart = 1;
@@ -78,15 +78,15 @@ class _HexDecoderSink extends StringConversionSinkBase {
   }
 
   ByteConversionSink asUtf8Sink(bool allowMalformed) =>
-      new _HexDecoderByteSink(_sink);
+      _HexDecoderByteSink(_sink);
 
   void close() => _close();
 
   /// Like [close], but includes [string] and [index] in the [FormatException]
   /// if one is thrown.
   void _close([String string, int index]) {
     if (_lastDigit != null) {
-      throw new FormatException(
+      throw FormatException(
           "Input ended with incomplete encoded byte.", string, index);
     }
 
@@ -121,11 +121,11 @@ class _HexDecoderByteSink extends ByteConversionSinkBase {
     Uint8List bytes;
     int bytesStart;
     if (_lastDigit == null) {
-      bytes = new Uint8List((end - start) ~/ 2);
+      bytes = Uint8List((end - start) ~/ 2);
       bytesStart = 0;
     } else {
       var hexPairs = (end - start - 1) ~/ 2;
-      bytes = new Uint8List(1 + hexPairs);
+      bytes = Uint8List(1 + hexPairs);
       bytes[0] = _lastDigit + digitForCodeUnit(chunk, start);
       start++;
       bytesStart = 1;
@@ -143,7 +143,7 @@ class _HexDecoderByteSink extends ByteConversionSinkBase {
   /// if one is thrown.
   void _close([List<int> chunk, int index]) {
     if (_lastDigit != null) {
-      throw new FormatException(
+      throw FormatException(
           "Input ended with incomplete encoded byte.", chunk, index);
     }
 

lib/src/hex/decoder.dart

@@ -10,7 +10,7 @@ import 'dart:typed_data';
 import 'package:charcode/ascii.dart';
 
 /// The canonical instance of [HexEncoder].
-const hexEncoder = const HexEncoder._();
+const hexEncoder = HexEncoder._();
 
 /// A converter that encodes byte arrays into hexadecimal strings.
 ///
@@ -22,7 +22,7 @@ class HexEncoder extends Converter<List<int>, String> {
   String convert(List<int> bytes) => _convert(bytes, 0, bytes.length);
 
   ByteConversionSink startChunkedConversion(Sink<String> sink) =>
-      new _HexEncoderSink(sink);
+      _HexEncoderSink(sink);
 }
 
 /// A conversion sink for chunked hexadecimal encoding.
@@ -51,7 +51,7 @@ String _convert(List<int> bytes, int start, int end) {
   // A Uint8List is more efficient than a StringBuffer given that we know that
   // we're only emitting ASCII-compatible characters, and that we know the
   // length ahead of time.
-  var buffer = new Uint8List((end - start) * 2);
+  var buffer = Uint8List((end - start) * 2);
   var bufferIndex = 0;
 
   // A bitwise OR of all bytes in [bytes]. This allows us to check for
@@ -69,13 +69,13 @@ String _convert(List<int> bytes, int start, int end) {
     buffer[bufferIndex++] = _codeUnitForDigit(byte & 0x0F);
   }
 
-  if (byteOr >= 0 && byteOr <= 255) return new String.fromCharCodes(buffer);
+  if (byteOr >= 0 && byteOr <= 255) return String.fromCharCodes(buffer);
 
   // If there was an invalid byte, find it and throw an exception.
   for (var i = start; i < end; i++) {
     var byte = bytes[i];
     if (byte >= 0 && byte <= 0xff) continue;
-    throw new FormatException(
+    throw FormatException(
         "Invalid byte ${byte < 0 ? "-" : ""}0x${byte.abs().toRadixString(16)}.",
         bytes,
         i);

lib/src/hex/encoder.dart

@@ -17,8 +17,8 @@ class _IdentityConverter<T> extends Converter<T, T> {
 class IdentityCodec<T> extends Codec<T, T> {
   const IdentityCodec();
 
-  Converter<T, T> get decoder => new _IdentityConverter<T>();
-  Converter<T, T> get encoder => new _IdentityConverter<T>();
+  Converter<T, T> get decoder => _IdentityConverter<T>();
+  Converter<T, T> get encoder => _IdentityConverter<T>();
 
   /// Fuse with an other codec.
   ///

lib/src/identity_codec.dart

@@ -6,14 +6,14 @@ library convert.percent;
 
 import 'dart:convert';
 
-import 'percent/encoder.dart';
 import 'percent/decoder.dart';
+import 'percent/encoder.dart';
 
-export 'percent/encoder.dart' hide percentEncoder;
 export 'percent/decoder.dart' hide percentDecoder;
+export 'percent/encoder.dart' hide percentEncoder;
 
 /// The canonical instance of [PercentCodec].
-const percent = const PercentCodec._();
+const percent = PercentCodec._();
 
 // TODO(nweiz): Add flags to support generating and interpreting "+" as a space
 // character. Also add an option for custom sets of unreserved characters.