Fix a crash in Chain.terse and Chain.foldFrames.

These methods didn't gracefully handle a chain with an empty frame,
which comes up occasionally in practice.

Closes flutter#9

[email protected]

Review URL: https://codereview.chromium.org//1492323004 .

Author: nex3

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.5.1
+
+* Fix a crash in `Chain.foldFrames()` and `Chain.terse` when one of the chain's
+  traces has no frames.
+
 ## 1.5.0
 
 * `new Chain.parse()` now parses all the stack trace formats supported by `new

lib/src/chain.dart

@@ -37,7 +37,6 @@ typedef void ChainHandler(error, Chain chain);
 ///             "$stackChain");
 ///     });
 class Chain implements StackTrace {
-
   /// The stack traces that make up this chain.
   ///
   /// Like the frames in a stack trace, the traces are ordered from most local
@@ -155,6 +154,7 @@ class Chain implements StackTrace {
     var nonEmptyTraces = foldedTraces.where((trace) {
       // Ignore traces that contain only folded frames.
       if (trace.frames.length > 1) return true;
+      if (trace.frames.isEmpty) return false;
 
       // In terse mode, the trace may have removed an outer folded frame,
       // leaving a single non-folded frame. We can detect a folded frame because

pubspec.yaml

@@ -7,7 +7,7 @@ name: stack_trace
 #
 # When the major version is upgraded, you *must* update that version constraint
 # in pub to stay in sync with this.
-version: 1.5.0
+version: 1.5.1
 author: "Dart Team <[email protected]>"
 homepage: http://github.com/dart-lang/stack_trace
 description: >

test/chain/chain_test.dart

@@ -109,6 +109,20 @@ void main() {
 
       expect(chain.terse.toString(), equals('dart:core  E.f\n'));
     });
+
+    // Regression test for #9
+    test("doesn't crash on empty traces", () {
+      var chain = new Chain([
+        new Trace.parse('user/code.dart 10:11  Bang.qux'),
+        new Trace([]),
+        new Trace.parse('user/code.dart 10:11  Bang.qux')
+      ]);
+
+      expect(chain.terse.toString(), equals(
+          '$userSlashCode 10:11  Bang.qux\n'
+          '===== asynchronous gap ===========================\n'
+          '$userSlashCode 10:11  Bang.qux\n'));
+    });
   });
 
   group('Chain.foldFrames', () {