feat: add support of Gitlab's sections for CODEOWNERS #32061

MaximeMorille · 2024-10-21T18:15:27Z

Changes

Add support for Gitlab's sections in CODEOWNERS files, notably their default approver feature.

Context

Closes GitLab CODEOWNERS: support for default section owner #29202

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required (not so sure about that, but I didn't find a part worthy of update)

How I've tested my work (please select one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository

rarkins

Does GitLab's approach conflict with other platforms, particularly GitHub? This change is in lib/workers which means it will apply to all platforms

MaximeMorille · 2024-10-22T18:13:33Z

Good point, it does conflict with Gitea format.

I will take a look at the platform folder to see if there is a way to implement this only for Gitlab.

MaximeMorille · 2024-12-11T07:12:11Z

Hello @declension, thanks for the reminder, I forgot this PR...

I am quite busy right now, I pushed the current state of my rework but I don't know when I will be able to complete it (I think tests may be improved). I should have some time to work on it in a few weeks.

Feel free to push a new PR to fix this issue, you can take any part of my work if needed 🙂

lib/workers/repository/update/pr/code-owners.spec.ts

github-actions · 2025-04-27T07:15:10Z

Hi there,

This PR appears to have been inactive for a while. Please let us know if you are still working on it, or if we can close it for now.

Thanks, the Renovate team

lib/workers/repository/update/pr/code-owners.ts

lib/modules/platform/gitlab/code-owners.spec.ts

lib/modules/platform/gitlab/code-owners.ts

lib/modules/platform/gitlab/index.ts

lib/workers/repository/update/pr/code-owners.ts

Co-authored-by: Michael Kriese <[email protected]>

renovate-release · 2025-06-07T09:29:38Z

🎉 This PR is included in version 40.47.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [renovate/renovate](https://renovatebot.com) ([source](https://github.com/renovatebot/renovate)) | minor | `40.42.5` -> `40.47.1` | --- ### Release Notes <details> <summary>renovatebot/renovate (renovate/renovate)</summary> ### [`v40.47.1`](https://github.com/renovatebot/renovate/releases/tag/40.47.1) [Compare Source](renovatebot/renovate@40.47.0...40.47.1) ##### Bug Fixes - **ci:** Skip coverage jobs when tests are failed ([#36371](renovatebot/renovate#36371)) ([a8e694e](renovatebot/renovate@a8e694e)) ##### Miscellaneous Chores - **deps:** update containerbase/internal-tools action to v3.10.42 (main) ([#36369](renovatebot/renovate#36369)) ([1e65b51](renovatebot/renovate@1e65b51)) ### [`v40.47.0`](https://github.com/renovatebot/renovate/releases/tag/40.47.0) [Compare Source](renovatebot/renovate@40.46.0...40.47.0) ##### Features - add support of Gitlab's sections for CODEOWNERS ([#32061](renovatebot/renovate#32061)) ([743ef8f](renovatebot/renovate@743ef8f)) ### [`v40.46.0`](https://github.com/renovatebot/renovate/releases/tag/40.46.0) [Compare Source](renovatebot/renovate@40.45.5...40.46.0) ##### Features - **manager/cargo:** support git dependencies ([#36289](renovatebot/renovate#36289)) ([7209da4](renovatebot/renovate@7209da4)) - **presets:** disable currently not supported gradle replacement PRs ([#36357](renovatebot/renovate#36357)) ([3592fa0](renovatebot/renovate@3592fa0)) ##### Bug Fixes - **deps:** update ghcr.io/renovatebot/base-image docker tag to v9.71.12 (main) ([#36368](renovatebot/renovate#36368)) ([1776522](renovatebot/renovate@1776522)) ### [`v40.45.5`](https://github.com/renovatebot/renovate/releases/tag/40.45.5) [Compare Source](renovatebot/renovate@40.45.4...40.45.5) ##### Bug Fixes - **deps:** update ghcr.io/renovatebot/base-image docker tag to v9.71.11 (main) ([#36366](renovatebot/renovate#36366)) ([ab14aa3](renovatebot/renovate@ab14aa3)) ### [`v40.45.4`](https://github.com/renovatebot/renovate/releases/tag/40.45.4) [Compare Source](renovatebot/renovate@40.45.3...40.45.4) ##### Bug Fixes - **deps:** update ghcr.io/renovatebot/base-image docker tag to v9.71.10 (main) ([#36365](renovatebot/renovate#36365)) ([ad52f18](renovatebot/renovate@ad52f18)) ### [`v40.45.3`](https://github.com/renovatebot/renovate/releases/tag/40.45.3) [Compare Source](renovatebot/renovate@40.45.2...40.45.3) ##### Bug Fixes - **deps:** update ghcr.io/renovatebot/base-image docker tag to v9.71.9 (main) ([#36364](renovatebot/renovate#36364)) ([95d4b4c](renovatebot/renovate@95d4b4c)) ### [`v40.45.2`](https://github.com/renovatebot/renovate/releases/tag/40.45.2) [Compare Source](renovatebot/renovate@40.45.1...40.45.2) ##### Bug Fixes - **deps:** update ghcr.io/renovatebot/base-image docker tag to v9.71.8 (main) ([#36363](renovatebot/renovate#36363)) ([4acc1bd](renovatebot/renovate@4acc1bd)) ### [`v40.45.1`](https://github.com/renovatebot/renovate/releases/tag/40.45.1) [Compare Source](renovatebot/renovate@40.44.0...40.45.1) ##### Bug Fixes - **deps:** update ghcr.io/renovatebot/base-image docker tag to v9.71.6 (main) ([#36361](renovatebot/renovate#36361)) ([9047db9](renovatebot/renovate@9047db9)) ##### Miscellaneous Chores - **deps:** update dependency [@types/node](https://github.com/types/node) to v22.15.29 (main) ([#36355](renovatebot/renovate#36355)) ([d0d1655](renovatebot/renovate@d0d1655)) - **deps:** update dependency eslint-import-resolver-typescript to v4.4.2 (main) ([#36359](renovatebot/renovate#36359)) ([f19e326](renovatebot/renovate@f19e326)) - **deps:** update dependency nock to v14.0.5 (main) ([#36356](renovatebot/renovate#36356)) ([65df35c](renovatebot/renovate@65df35c)) - **deps:** update linters to v9.28.0 (main) ([#36358](renovatebot/renovate#36358)) ([a362e17](renovatebot/renovate@a362e17)) ##### Build System - **deps:** update dependency ignore to v7.0.5 (main) ([#36362](renovatebot/renovate#36362)) ([1367e68](renovatebot/renovate@1367e68)) ### [`v40.44.0`](https://github.com/renovatebot/renovate/releases/tag/40.44.0) [Compare Source](renovatebot/renovate@40.43.1...40.44.0) ##### Features - **manager/mise:** committed, hk, lefthook and ruff shortnames ([#36252](renovatebot/renovate#36252)) ([95dac96](renovatebot/renovate@95dac96)) ### [`v40.43.1`](https://github.com/renovatebot/renovate/releases/tag/40.43.1) [Compare Source](renovatebot/renovate@40.43.0...40.43.1) ##### Bug Fixes - **manager/docker-compose:** update images used as anchors ([#35844](renovatebot/renovate#35844)) ([72bc1fb](renovatebot/renovate@72bc1fb)) ### [`v40.43.0`](https://github.com/renovatebot/renovate/releases/tag/40.43.0) [Compare Source](renovatebot/renovate@40.42.5...40.43.0) ##### Features - **manager:** CNB support for Spring Boot maven plugin ([#35183](renovatebot/renovate#35183)) ([c9c87fc](renovatebot/renovate@c9c87fc)) ##### Build System - **deps:** update dependency zod to v3.25.42 (main) ([#36348](renovatebot/renovate#36348)) ([dae2f1f](renovatebot/renovate@dae2f1f)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.prettysunflower.moe/prettysunflower/infra/pulls/8 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

MaximeMorille changed the title ~~Add support of Gitlab's sections for CODEOWNERS (#29202)~~ feat: add support of Gitlab's sections for CODEOWNERS (#29202) Oct 21, 2024

rarkins reviewed Oct 22, 2024

View reviewed changes

MaximeMorille marked this pull request as draft October 22, 2024 18:13

This comment has been minimized.

Sign in to view

MaximeMorille force-pushed the feat/29202-supports-gitlab-sections branch from e4ff16b to 6a69f1f Compare December 10, 2024 18:51

MaximeMorille force-pushed the feat/29202-supports-gitlab-sections branch from e0390d5 to 3b07dee Compare January 23, 2025 05:25

MaximeMorille commented Jan 23, 2025

View reviewed changes

lib/workers/repository/update/pr/code-owners.spec.ts Outdated Show resolved Hide resolved

MaximeMorille marked this pull request as ready for review January 23, 2025 05:56

MaximeMorille requested a review from rarkins January 23, 2025 16:34

rarkins added the auto:inactive-pr PR has become inactive and we want to prompt the submitter label Apr 27, 2025

MaximeMorille added 4 commits April 28, 2025 20:29

Add support of Gitlab's sections for CODEOWNERS (renovatebot#29202)

2e63467

Add a specific implementation to parse Gitlab CODEOWNERS

3432b79

Add tests

85730a7

Fix tests after vitest migration

81ec5cf

MaximeMorille force-pushed the feat/29202-supports-gitlab-sections branch from 30d87a6 to 81ec5cf Compare April 28, 2025 19:39

rarkins suggested changes Apr 30, 2025

View reviewed changes

lib/workers/repository/update/pr/code-owners.ts Show resolved Hide resolved

MaximeMorille and others added 2 commits May 5, 2025 06:20

Merge branch 'main' into feat/29202-supports-gitlab-sections

5b8ffc8

Deduplicate file parsing

57d095f

MaximeMorille requested a review from rarkins May 5, 2025 04:53

Merge branch 'main' into feat/29202-supports-gitlab-sections

8a061a9

viceice reviewed May 8, 2025

View reviewed changes

MaximeMorille added 2 commits May 9, 2025 08:37

Fix tests

02e2cef

Reimplement Gitlab codeowners parser as a function

4ba0c98

MaximeMorille requested a review from viceice May 9, 2025 07:14

Merge branch 'main' into feat/29202-supports-gitlab-sections

dbd6bef

rarkins removed the auto:inactive-pr PR has become inactive and we want to prompt the submitter label May 21, 2025

Merge branch 'main' into feat/29202-supports-gitlab-sections

3a5ba20

viceice changed the title ~~feat: add support of Gitlab's sections for CODEOWNERS (#29202)~~ feat: add support of Gitlab's sections for CODEOWNERS Jun 2, 2025

viceice reviewed Jun 4, 2025

View reviewed changes

lib/workers/repository/update/pr/code-owners.ts Outdated Show resolved Hide resolved

MaximeMorille and others added 2 commits June 5, 2025 11:22

Update lib/workers/repository/update/pr/code-owners.ts

4bdec9c

Co-authored-by: Michael Kriese <[email protected]>

Fix optional chaining syntax

1129c6f

MaximeMorille requested a review from viceice June 6, 2025 07:26

Merge branch 'main' into feat/29202-supports-gitlab-sections

2764fc6

viceice approved these changes Jun 6, 2025

View reviewed changes

rarkins approved these changes Jun 7, 2025

View reviewed changes

rarkins added this pull request to the merge queue Jun 7, 2025

Merged via the queue into renovatebot:main with commit 743ef8f Jun 7, 2025
40 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add support of Gitlab's sections for CODEOWNERS #32061

feat: add support of Gitlab's sections for CODEOWNERS #32061

Uh oh!

MaximeMorille commented Oct 21, 2024 •

edited by viceice

Loading

Uh oh!

rarkins left a comment

Uh oh!

MaximeMorille commented Oct 22, 2024

Uh oh!

This comment has been minimized.

MaximeMorille commented Dec 11, 2024

Uh oh!

Uh oh!

github-actions bot commented Apr 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

renovate-release commented Jun 7, 2025

Uh oh!

Uh oh!

feat: add support of Gitlab's sections for CODEOWNERS #32061

feat: add support of Gitlab's sections for CODEOWNERS #32061

Uh oh!

Conversation

MaximeMorille commented Oct 21, 2024 • edited by viceice Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please select one)

Uh oh!

rarkins left a comment

Choose a reason for hiding this comment

Uh oh!

MaximeMorille commented Oct 22, 2024

Uh oh!

This comment has been minimized.

MaximeMorille commented Dec 11, 2024

Uh oh!

Uh oh!

github-actions bot commented Apr 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

renovate-release commented Jun 7, 2025

Uh oh!

Uh oh!

MaximeMorille commented Oct 21, 2024 •

edited by viceice

Loading