Fix Service.OwnedResources() to return correct result

We were bitten by https://github.com/golang/go/wiki/CommonMistakes#using-reference-to-loop-iterator-variable

Fixed the loop to use the new variable.

Signed-off-by: Predrag Knezevic <[email protected]>

Author: pedjak

pkg/reconcile/pipeline/context/service.go

@@ -63,7 +63,8 @@ func (s *service) OwnedResources() ([]*unstructured.Unstructured, error) {
 			}
 			return nil, err
 		}
-		for _, item := range list.Items {
+		for i := range list.Items {
+			item := list.Items[i]
 			for _, ownerRef := range item.GetOwnerReferences() {
 				if reflect.DeepEqual(ownerRef.UID, uid) {
 					result = append(result, &item)

pkg/reconcile/pipeline/context/service_test.go

@@ -5,11 +5,15 @@ import (
 	. "github.com/onsi/ginkgo/extensions/table"
 	. "github.com/onsi/gomega"
 	"github.com/redhat-developer/service-binding-operator/api/v1alpha1"
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/runtime/schema"
+	"k8s.io/apimachinery/pkg/types"
+	"k8s.io/apimachinery/pkg/util/uuid"
 	"k8s.io/client-go/dynamic"
 	"k8s.io/client-go/dynamic/fake"
+	"strings"
 )
 
 var _ = Describe("Service", func() {
@@ -43,8 +47,55 @@ var _ = Describe("Service", func() {
 		Expect(res).To(BeNil())
 	})
 
+	It("should return owned resources", func() {
+		var objs []runtime.Object
+		id := uuid.NewUUID()
+		id2 := uuid.NewUUID()
+		ns := "ns1"
+		u := &unstructured.Unstructured{}
+		u.SetGroupVersionKind(schema.GroupVersionKind{Group: "foo.bar", Version: "v1", Kind: "Foo"})
+		u.SetName("foo")
+		u.SetNamespace(ns)
+		u.SetUID(id)
+
+		objs = append(objs, u)
+
+		var children []interface{}
+
+		for _, gvr := range bindableResourceGVRs {
+			gvk := gvr.GroupVersion().WithKind(strings.Title(gvr.Resource)[:len(gvr.Resource)-1])
+			ou := resource(gvk, "child1", ns, id)
+
+			ou2 := resource(gvk, "child2", ns, id2)
+
+			children = append(children, ou)
+			objs = append(objs, ou, ou2)
+		}
+
+		client = fake.NewSimpleDynamicClient(runtime.NewScheme(), objs...)
+
+		impl := &service{client: client, resource: u, lookForOwnedResources: true, serviceRef: &v1alpha1.Service{ NamespacedRef: v1alpha1.NamespacedRef{Namespace: &ns}}}
+
+		ownedResources, err := impl.OwnedResources()
+		Expect(err).NotTo(HaveOccurred())
+		Expect(ownedResources).Should(HaveLen(len(bindableResourceGVRs)))
+		Expect(ownedResources).Should(ContainElements(children...))
+	})
 })
 
+func resource(gvk schema.GroupVersionKind, name string, namespace string, owner types.UID) *unstructured.Unstructured {
+	u := &unstructured.Unstructured{}
+	u.SetGroupVersionKind(gvk)
+	u.SetName(name)
+	u.SetNamespace(namespace)
+	u.SetOwnerReferences([]v1.OwnerReference {
+		{
+			UID: owner,
+		},
+	})
+	return u
+}
+
 func crd(version string, gr schema.GroupResource) *unstructured.Unstructured {
 	u := &unstructured.Unstructured{}
 	u.SetGroupVersionKind(schema.GroupVersionKind{Group: "apiextensions.k8s.io", Version: version, Kind: "CustomResourceDefinition"})