Fix issue with the "Executing application" spinner never ending in KubeExec implementation

Spinner handling will be done in the KubeExecProcessHandler#Execute method itself,
which executes the overridden command in a goroutine.
Otherwise, we might end up with a never-ending spinner,
because the overridden command might be a long-running process.

Author: rm3l

pkg/devfile/adapters/kubernetes/component/remotecmd/kubeexec.go

@@ -19,7 +19,7 @@ import (
 
 const (
 	_startCmdProcessPidFile = "/opt/odo/.odo_devfile_cmd.pid"
-	_sigtermExitCode = 143
+	_sigtermExitCode        = 143
 )
 
 // kubeExecProcessHandler implements RemoteProcessHandler by executing Devfile commands right away in the container
@@ -132,10 +132,11 @@ func (k *kubeExecProcessHandler) GetStartStopCommands(
 // by killing the underlying remote process via the Stop command returned by GetStartStopCommands.
 // Note that resultHandler is invoked once the command is done.
 func (k *kubeExecProcessHandlerStartCommand) Execute(show bool, resultHandler command.ExecuteResultHandler) error {
-	spinner := log.SpinnerNoSpin(k.msg)
-	go func(spinner *log.Status) {
-		defer spinner.End(false)
-		err := k.cmd.Execute(show, func(stdout []string, stderr []string, err error) {
+	//We use a static spinner here, because otherwise, ending the spinner will cause the "•  Executing the application  ..."
+	//message to be displayed twice once the spinner ends
+	_ = log.SpinnerNoSpin(k.msg)
+	go func() {
+		_ = k.cmd.Execute(show, func(stdout []string, stderr []string, err error) {
 			if resultHandler != nil {
 				resultHandler(stdout, stderr, err)
 			}
@@ -155,10 +156,7 @@ func (k *kubeExecProcessHandlerStartCommand) Execute(show bool, resultHandler co
 				}
 			}
 		})
-		if err == nil {
-			spinner.End(true)
-		}
-	}(spinner)
+	}()
 	return nil
 }