Skip to content

Commit d76ba7b

Browse files
authored
Merge pull request #238 from clue-labs/dequeue
Remove internal `Queue` leftovers
2 parents ee59eae + 42f7fcc commit d76ba7b

File tree

5 files changed

+10
-136
lines changed

5 files changed

+10
-136
lines changed

src/Internal/FulfilledPromise.php

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22

33
namespace React\Promise\Internal;
44

5-
use React\Promise\Promise;
65
use React\Promise\PromiseInterface;
7-
use function React\Promise\enqueue;
86
use function React\Promise\resolve;
97

108
/**
@@ -29,15 +27,11 @@ public function then(callable $onFulfilled = null, callable $onRejected = null):
2927
return $this;
3028
}
3129

32-
return new Promise(function (callable $resolve, callable $reject) use ($onFulfilled): void {
33-
enqueue(function () use ($resolve, $reject, $onFulfilled): void {
34-
try {
35-
$resolve($onFulfilled($this->value));
36-
} catch (\Throwable $exception) {
37-
$reject($exception);
38-
}
39-
});
40-
});
30+
try {
31+
return resolve($onFulfilled($this->value));
32+
} catch (\Throwable $exception) {
33+
return new RejectedPromise($exception);
34+
}
4135
}
4236

4337
public function catch(callable $onRejected): PromiseInterface

src/Internal/Queue.php

Lines changed: 0 additions & 30 deletions
This file was deleted.

src/Internal/RejectedPromise.php

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,8 @@
22

33
namespace React\Promise\Internal;
44

5-
use React\Promise\Promise;
65
use React\Promise\PromiseInterface;
76
use function React\Promise\_checkTypehint;
8-
use function React\Promise\enqueue;
97
use function React\Promise\resolve;
108

119
/**
@@ -26,15 +24,11 @@ public function then(callable $onFulfilled = null, callable $onRejected = null):
2624
return $this;
2725
}
2826

29-
return new Promise(function (callable $resolve, callable $reject) use ($onRejected): void {
30-
enqueue(function () use ($resolve, $reject, $onRejected): void {
31-
try {
32-
$resolve($onRejected($this->reason));
33-
} catch (\Throwable $exception) {
34-
$reject($exception);
35-
}
36-
});
37-
});
27+
try {
28+
return resolve($onRejected($this->reason));
29+
} catch (\Throwable $exception) {
30+
return new RejectedPromise($exception);
31+
}
3832
}
3933

4034
public function catch(callable $onRejected): PromiseInterface

src/functions.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -205,20 +205,6 @@ function (\Throwable $reason) use ($i, &$reasons, &$toReject, $reject, &$continu
205205
}, $cancellationQueue);
206206
}
207207

208-
/**
209-
* @internal
210-
*/
211-
function enqueue(callable $task): void
212-
{
213-
static $queue;
214-
215-
if (!$queue) {
216-
$queue = new Internal\Queue();
217-
}
218-
219-
$queue->enqueue($task);
220-
}
221-
222208
/**
223209
* @internal
224210
*/

tests/Internal/QueueTest.php

Lines changed: 0 additions & 70 deletions
This file was deleted.

0 commit comments

Comments
 (0)