Merge pull request #213 from clue-labs/resolve-argument

Require argument for `resolve()` function

Author: WyriHaximus

README.md

@@ -96,7 +96,7 @@ $deferred = new React\Promise\Deferred();
 
 $promise = $deferred->promise();
 
-$deferred->resolve(mixed $value = null);
+$deferred->resolve(mixed $value);
 $deferred->reject(\Throwable $reason);
 ```
 
@@ -119,7 +119,7 @@ keeping the authority to modify its state to yourself.
 #### Deferred::resolve()
 
 ```php
-$deferred->resolve(mixed $value = null);
+$deferred->resolve(mixed $value);
 ```
 
 Resolves the promise returned by `promise()`. All consumers are notified by

src/Deferred.php

@@ -21,7 +21,7 @@ public function promise(): PromiseInterface
         return $this->promise;
     }
 
-    public function resolve($value = null): void
+    public function resolve($value): void
     {
         ($this->resolveCallback)($value);
     }

src/Promise.php

@@ -239,7 +239,7 @@ private function call(callable $cb): void
                 $target =& $this;
 
                 $callback(
-                    static function ($value = null) use (&$target) {
+                    static function ($value) use (&$target) {
                         if ($target !== null) {
                             $target->settle(resolve($value));
                             $target = null;

src/functions.php

@@ -20,8 +20,7 @@
  * @param mixed $promiseOrValue
  * @return PromiseInterface
  */
-
-function resolve($promiseOrValue = null): PromiseInterface
+function resolve($promiseOrValue): PromiseInterface
 {
     if ($promiseOrValue instanceof PromiseInterface) {
         return $promiseOrValue;
@@ -346,7 +345,7 @@ function _checkTypehint(callable $callback, \Throwable $reason): bool
 
     // Extract the type of the argument and handle different possibilities
     $type = $expectedException->getType();
-    
+
     $isTypeUnion = true;
     $types = [];
 

tests/FunctionAnyTest.php

@@ -122,7 +122,7 @@ public function shouldCancelInputArrayPromises()
     public function shouldNotCancelOtherPendingInputArrayPromisesIfOnePromiseFulfills()
     {
         $deferred = new Deferred($this->expectCallableNever());
-        $deferred->resolve();
+        $deferred->resolve(null);
 
         $promise2 = new Promise(function () {}, $this->expectCallableNever());
 

tests/FunctionRaceTest.php

@@ -103,7 +103,7 @@ public function shouldCancelInputArrayPromises()
     public function shouldNotCancelOtherPendingInputArrayPromisesIfOnePromiseFulfills()
     {
         $deferred = new Deferred($this->expectCallableNever());
-        $deferred->resolve();
+        $deferred->resolve(null);
 
         $promise2 = new Promise(function () {}, $this->expectCallableNever());
 

tests/FunctionSomeTest.php

@@ -148,7 +148,7 @@ public function shouldCancelInputArrayPromises()
     public function shouldCancelOtherPendingInputArrayPromisesIfEnoughPromisesFulfill()
     {
         $deferred = new Deferred($this->expectCallableNever());
-        $deferred->resolve();
+        $deferred->resolve(null);
 
         $promise2 = new Promise(function () {}, $this->expectCallableNever());
 

tests/PromiseTest/CancelTestTrait.php

@@ -110,7 +110,7 @@ public function cancelShouldCallCancellerOnlyOnceIfCancellerResolves()
             ->expects($this->once())
             ->method('__invoke')
             ->will($this->returnCallback(function ($resolve) {
-                $resolve();
+                $resolve(null);
             }));
 
         $adapter = $this->getPromiseTestAdapter($mock);

tests/PromiseTest/PromiseFulfilledTestTrait.php

@@ -190,7 +190,7 @@ public function cancelShouldReturnNullForFulfilledPromise()
     {
         $adapter = $this->getPromiseTestAdapter();
 
-        $adapter->resolve();
+        $adapter->resolve(null);
 
         self::assertNull($adapter->promise()->cancel());
     }
@@ -200,7 +200,7 @@ public function cancelShouldHaveNoEffectForFulfilledPromise()
     {
         $adapter = $this->getPromiseTestAdapter($this->expectCallableNever());
 
-        $adapter->resolve();
+        $adapter->resolve(null);
 
         $adapter->promise()->cancel();
     }

tests/PromiseTest/PromisePendingTestTrait.php

@@ -57,7 +57,7 @@ public function catchShouldNotInvokeRejectionHandlerForPendingPromise()
     {
         $adapter = $this->getPromiseTestAdapter();
 
-        $adapter->settle();
+        $adapter->settle(null);
         $adapter->promise()->catch($this->expectCallableNever());
     }
 
@@ -77,7 +77,7 @@ public function otherwiseShouldNotInvokeRejectionHandlerForPendingPromise()
     {
         $adapter = $this->getPromiseTestAdapter();
 
-        $adapter->settle();
+        $adapter->settle(null);
         $adapter->promise()->otherwise($this->expectCallableNever());
     }