Skip to content

Commit 4b4bb93

Browse files
authored
Merge pull request #56 from reactphp-parallel/renovate/react-promise-3.x
Update dependency react/promise to v3
2 parents 6d7e4b9 + dc15ba1 commit 4b4bb93

File tree

3 files changed

+11
-17
lines changed

3 files changed

+11
-17
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"ext-parallel": "*",
1515
"react-parallel/event-loop": "dev-master as 2.0",
1616
"react/event-loop": "^1.1",
17-
"react/promise": "^2.7",
17+
"react/promise": "^2.7 || ^3.0",
1818
"wyrihaximus/constants": "^1.6"
1919
},
2020
"require-dev": {

composer.lock

Lines changed: 10 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/RuntimeTest.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,15 @@
66

77
use parallel\Runtime\Error\Closed;
88
use React\EventLoop\Loop;
9-
use React\Promise\ExtendedPromiseInterface;
109
use ReactParallel\EventLoop\EventLoopBridge;
1110
use ReactParallel\Runtime\Runtime;
1211
use TheOrville\Exceptions\LatchcombException;
1312
use WyriHaximus\AsyncTestUtilities\AsyncTestCase;
1413

15-
use function assert;
1614
use function React\Async\await;
1715
use function sleep;
1816
use function WyriHaximus\React\timedPromise;
1917

20-
/** @internal */
2118
final class RuntimeTest extends AsyncTestCase
2219
{
2320
/** @test */
@@ -30,7 +27,6 @@ public function convertSuccess(): void
3027

3128
return 3;
3229
});
33-
assert($promise instanceof ExtendedPromiseInterface);
3430

3531
$promise->always(static function () use ($runtime): void {
3632
$runtime->kill();
@@ -54,7 +50,6 @@ public function convertFailure(): void
5450

5551
throw new LatchcombException('Rethrow exception');
5652
});
57-
assert($promise instanceof ExtendedPromiseInterface);
5853

5954
$promise->always(static function () use ($runtime): void {
6055
$runtime->close();
@@ -78,7 +73,6 @@ public function weClosedTheThread(): void
7873
return 3;
7974
});
8075
});
81-
assert($promise instanceof ExtendedPromiseInterface);
8276

8377
Loop::futureTick(static function () use ($runtime): void {
8478
$runtime->close();
@@ -100,7 +94,6 @@ public function weKilledTheThread(): void
10094
return 3;
10195
});
10296
});
103-
assert($promise instanceof ExtendedPromiseInterface);
10497

10598
Loop::futureTick(static function () use ($runtime): void {
10699
$runtime->kill();

0 commit comments

Comments
 (0)