Skip to content

Commit 33c21c0

Browse files
hoxyqhoxyq
committed
Suggest correct casing for misspelled credentialless iframe attribute (#36322)
## Summary Follow-up to #36148 (which added credentialless as a recognized boolean attribute for iframes). Adds credentialless to possibleStandardNames so React's dev warning can suggest the correct casing when users write it as Credentialless (or another incorrect case). Includes an SSR test asserting the "Did you mean credentialless?" warning fires. ## Test plan - yarn test ReactDOMComponent passes, including the new should warn about incorrect casing on the credentialless property (ssr) case DiffTrain build for [94643c3](94643c3)
1 parent 9f2aa12 commit 33c21c0

21 files changed

Lines changed: 74 additions & 72 deletions

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.3.0-native-fb-306a01b4-20260420
1+
19.3.0-native-fb-94643c3b-20260421

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<b65d84e7ec7daa9e1c991f910ba8ae9d>>
10+
* @generated SignedSource<<e039b4e78b93af670d03e6e779d75ded>>
1111
*/
1212

1313
"use strict";
@@ -410,5 +410,5 @@ __DEV__ &&
410410
exports.useFormStatus = function () {
411411
return resolveDispatcher().useHostTransitionStatus();
412412
};
413-
exports.version = "19.3.0-native-fb-306a01b4-20260420";
413+
exports.version = "19.3.0-native-fb-94643c3b-20260421";
414414
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<eee419d99d60c98fb76bf6be5a915e82>>
10+
* @generated SignedSource<<7ea1198a5d1ebb1342f65fd73756bb3b>>
1111
*/
1212

1313
"use strict";
@@ -209,4 +209,4 @@ exports.useFormState = function (action, initialState, permalink) {
209209
exports.useFormStatus = function () {
210210
return ReactSharedInternals.H.useHostTransitionStatus();
211211
};
212-
exports.version = "19.3.0-native-fb-306a01b4-20260420";
212+
exports.version = "19.3.0-native-fb-94643c3b-20260421";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<eee419d99d60c98fb76bf6be5a915e82>>
10+
* @generated SignedSource<<7ea1198a5d1ebb1342f65fd73756bb3b>>
1111
*/
1212

1313
"use strict";
@@ -209,4 +209,4 @@ exports.useFormState = function (action, initialState, permalink) {
209209
exports.useFormStatus = function () {
210210
return ReactSharedInternals.H.useHostTransitionStatus();
211211
};
212-
exports.version = "19.3.0-native-fb-306a01b4-20260420";
212+
exports.version = "19.3.0-native-fb-94643c3b-20260421";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a72152db42805b05f9c19c086c9f5994>>
10+
* @generated SignedSource<<96407ddfaf7e881d959a28f9e5a34686>>
1111
*/
1212

1313
/*
@@ -28159,6 +28159,7 @@ __DEV__ &&
2815928159
controls: "controls",
2816028160
controlslist: "controlsList",
2816128161
coords: "coords",
28162+
credentialless: "credentialless",
2816228163
crossorigin: "crossOrigin",
2816328164
dangerouslysetinnerhtml: "dangerouslySetInnerHTML",
2816428165
data: "data",
@@ -31911,11 +31912,11 @@ __DEV__ &&
3191131912
};
3191231913
(function () {
3191331914
var isomorphicReactPackageVersion = React.version;
31914-
if ("19.3.0-native-fb-306a01b4-20260420" !== isomorphicReactPackageVersion)
31915+
if ("19.3.0-native-fb-94643c3b-20260421" !== isomorphicReactPackageVersion)
3191531916
throw Error(
3191631917
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
3191731918
(isomorphicReactPackageVersion +
31918-
"\n - react-dom: 19.3.0-native-fb-306a01b4-20260420\nLearn more: https://react.dev/warnings/version-mismatch")
31919+
"\n - react-dom: 19.3.0-native-fb-94643c3b-20260421\nLearn more: https://react.dev/warnings/version-mismatch")
3191931920
);
3192031921
})();
3192131922
("function" === typeof Map &&
@@ -31952,10 +31953,10 @@ __DEV__ &&
3195231953
!(function () {
3195331954
var internals = {
3195431955
bundleType: 1,
31955-
version: "19.3.0-native-fb-306a01b4-20260420",
31956+
version: "19.3.0-native-fb-94643c3b-20260421",
3195631957
rendererPackageName: "react-dom",
3195731958
currentDispatcherRef: ReactSharedInternals,
31958-
reconcilerVersion: "19.3.0-native-fb-306a01b4-20260420"
31959+
reconcilerVersion: "19.3.0-native-fb-94643c3b-20260421"
3195931960
};
3196031961
internals.overrideHookState = overrideHookState;
3196131962
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -32105,5 +32106,5 @@ __DEV__ &&
3210532106
listenToAllSupportedEvents(container);
3210632107
return new ReactDOMHydrationRoot(initialChildren);
3210732108
};
32108-
exports.version = "19.3.0-native-fb-306a01b4-20260420";
32109+
exports.version = "19.3.0-native-fb-94643c3b-20260421";
3210932110
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<fe6eea63c0e49e7f5cb05be31173093b>>
10+
* @generated SignedSource<<f7f2869cd87f99ac670747e84c784989>>
1111
*/
1212

1313
/*
@@ -19094,14 +19094,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1909419094
};
1909519095
var isomorphicReactPackageVersion$jscomp$inline_2130 = React.version;
1909619096
if (
19097-
"19.3.0-native-fb-306a01b4-20260420" !==
19097+
"19.3.0-native-fb-94643c3b-20260421" !==
1909819098
isomorphicReactPackageVersion$jscomp$inline_2130
1909919099
)
1910019100
throw Error(
1910119101
formatProdErrorMessage(
1910219102
527,
1910319103
isomorphicReactPackageVersion$jscomp$inline_2130,
19104-
"19.3.0-native-fb-306a01b4-20260420"
19104+
"19.3.0-native-fb-94643c3b-20260421"
1910519105
)
1910619106
);
1910719107
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19123,10 +19123,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1912319123
};
1912419124
var internals$jscomp$inline_2726 = {
1912519125
bundleType: 0,
19126-
version: "19.3.0-native-fb-306a01b4-20260420",
19126+
version: "19.3.0-native-fb-94643c3b-20260421",
1912719127
rendererPackageName: "react-dom",
1912819128
currentDispatcherRef: ReactSharedInternals,
19129-
reconcilerVersion: "19.3.0-native-fb-306a01b4-20260420"
19129+
reconcilerVersion: "19.3.0-native-fb-94643c3b-20260421"
1913019130
};
1913119131
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1913219132
var hook$jscomp$inline_2727 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -19233,4 +19233,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1923319233
listenToAllSupportedEvents(container);
1923419234
return new ReactDOMHydrationRoot(initialChildren);
1923519235
};
19236-
exports.version = "19.3.0-native-fb-306a01b4-20260420";
19236+
exports.version = "19.3.0-native-fb-94643c3b-20260421";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e52cf5e6195d2ad47bfca842a1acd695>>
10+
* @generated SignedSource<<022aec860a511807d7ccb29361355ec1>>
1111
*/
1212

1313
/*
@@ -21156,14 +21156,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
2115621156
};
2115721157
var isomorphicReactPackageVersion$jscomp$inline_2477 = React.version;
2115821158
if (
21159-
"19.3.0-native-fb-306a01b4-20260420" !==
21159+
"19.3.0-native-fb-94643c3b-20260421" !==
2116021160
isomorphicReactPackageVersion$jscomp$inline_2477
2116121161
)
2116221162
throw Error(
2116321163
formatProdErrorMessage(
2116421164
527,
2116521165
isomorphicReactPackageVersion$jscomp$inline_2477,
21166-
"19.3.0-native-fb-306a01b4-20260420"
21166+
"19.3.0-native-fb-94643c3b-20260421"
2116721167
)
2116821168
);
2116921169
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -21185,10 +21185,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
2118521185
};
2118621186
var internals$jscomp$inline_2484 = {
2118721187
bundleType: 0,
21188-
version: "19.3.0-native-fb-306a01b4-20260420",
21188+
version: "19.3.0-native-fb-94643c3b-20260421",
2118921189
rendererPackageName: "react-dom",
2119021190
currentDispatcherRef: ReactSharedInternals,
21191-
reconcilerVersion: "19.3.0-native-fb-306a01b4-20260420",
21191+
reconcilerVersion: "19.3.0-native-fb-94643c3b-20260421",
2119221192
getLaneLabelMap: function () {
2119321193
for (
2119421194
var map = new Map(), lane = 1, index$346 = 0;
@@ -21311,4 +21311,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
2131121311
listenToAllSupportedEvents(container);
2131221312
return new ReactDOMHydrationRoot(initialChildren);
2131321313
};
21314-
exports.version = "19.3.0-native-fb-306a01b4-20260420";
21314+
exports.version = "19.3.0-native-fb-94643c3b-20260421";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5a98cf8eefa3a73c7f9d7e938f17c570>>
10+
* @generated SignedSource<<c371224987b1c2a6858ce051ca20cc96>>
1111
*/
1212

1313
/*
@@ -28221,6 +28221,7 @@ __DEV__ &&
2822128221
controls: "controls",
2822228222
controlslist: "controlsList",
2822328223
coords: "coords",
28224+
credentialless: "credentialless",
2822428225
crossorigin: "crossOrigin",
2822528226
dangerouslysetinnerhtml: "dangerouslySetInnerHTML",
2822628227
data: "data",
@@ -31973,11 +31974,11 @@ __DEV__ &&
3197331974
};
3197431975
(function () {
3197531976
var isomorphicReactPackageVersion = React.version;
31976-
if ("19.3.0-native-fb-306a01b4-20260420" !== isomorphicReactPackageVersion)
31977+
if ("19.3.0-native-fb-94643c3b-20260421" !== isomorphicReactPackageVersion)
3197731978
throw Error(
3197831979
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
3197931980
(isomorphicReactPackageVersion +
31980-
"\n - react-dom: 19.3.0-native-fb-306a01b4-20260420\nLearn more: https://react.dev/warnings/version-mismatch")
31981+
"\n - react-dom: 19.3.0-native-fb-94643c3b-20260421\nLearn more: https://react.dev/warnings/version-mismatch")
3198131982
);
3198231983
})();
3198331984
("function" === typeof Map &&
@@ -32014,10 +32015,10 @@ __DEV__ &&
3201432015
!(function () {
3201532016
var internals = {
3201632017
bundleType: 1,
32017-
version: "19.3.0-native-fb-306a01b4-20260420",
32018+
version: "19.3.0-native-fb-94643c3b-20260421",
3201832019
rendererPackageName: "react-dom",
3201932020
currentDispatcherRef: ReactSharedInternals,
32020-
reconcilerVersion: "19.3.0-native-fb-306a01b4-20260420"
32021+
reconcilerVersion: "19.3.0-native-fb-94643c3b-20260421"
3202132022
};
3202232023
internals.overrideHookState = overrideHookState;
3202332024
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -32483,7 +32484,7 @@ __DEV__ &&
3248332484
exports.useFormStatus = function () {
3248432485
return resolveDispatcher().useHostTransitionStatus();
3248532486
};
32486-
exports.version = "19.3.0-native-fb-306a01b4-20260420";
32487+
exports.version = "19.3.0-native-fb-94643c3b-20260421";
3248732488
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
3248832489
"function" ===
3248932490
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<402d6809ccd00a4fd008b67fe3de1828>>
10+
* @generated SignedSource<<fa61f4b1e41cbf1dc309424b02138314>>
1111
*/
1212

1313
/*
@@ -19111,14 +19111,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1911119111
};
1911219112
var isomorphicReactPackageVersion$jscomp$inline_2131 = React.version;
1911319113
if (
19114-
"19.3.0-native-fb-306a01b4-20260420" !==
19114+
"19.3.0-native-fb-94643c3b-20260421" !==
1911519115
isomorphicReactPackageVersion$jscomp$inline_2131
1911619116
)
1911719117
throw Error(
1911819118
formatProdErrorMessage(
1911919119
527,
1912019120
isomorphicReactPackageVersion$jscomp$inline_2131,
19121-
"19.3.0-native-fb-306a01b4-20260420"
19121+
"19.3.0-native-fb-94643c3b-20260421"
1912219122
)
1912319123
);
1912419124
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19140,10 +19140,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1914019140
};
1914119141
var internals$jscomp$inline_2729 = {
1914219142
bundleType: 0,
19143-
version: "19.3.0-native-fb-306a01b4-20260420",
19143+
version: "19.3.0-native-fb-94643c3b-20260421",
1914419144
rendererPackageName: "react-dom",
1914519145
currentDispatcherRef: ReactSharedInternals,
19146-
reconcilerVersion: "19.3.0-native-fb-306a01b4-20260420"
19146+
reconcilerVersion: "19.3.0-native-fb-94643c3b-20260421"
1914719147
};
1914819148
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1914919149
var hook$jscomp$inline_2730 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -19403,4 +19403,4 @@ exports.useFormState = function (action, initialState, permalink) {
1940319403
exports.useFormStatus = function () {
1940419404
return ReactSharedInternals.H.useHostTransitionStatus();
1940519405
};
19406-
exports.version = "19.3.0-native-fb-306a01b4-20260420";
19406+
exports.version = "19.3.0-native-fb-94643c3b-20260421";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5b9db0534d7821c0af5dfbb5ea32294e>>
10+
* @generated SignedSource<<8872f9acd8d7da95c709fa41051b6ec8>>
1111
*/
1212

1313
/*
@@ -21177,14 +21177,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
2117721177
};
2117821178
var isomorphicReactPackageVersion$jscomp$inline_2478 = React.version;
2117921179
if (
21180-
"19.3.0-native-fb-306a01b4-20260420" !==
21180+
"19.3.0-native-fb-94643c3b-20260421" !==
2118121181
isomorphicReactPackageVersion$jscomp$inline_2478
2118221182
)
2118321183
throw Error(
2118421184
formatProdErrorMessage(
2118521185
527,
2118621186
isomorphicReactPackageVersion$jscomp$inline_2478,
21187-
"19.3.0-native-fb-306a01b4-20260420"
21187+
"19.3.0-native-fb-94643c3b-20260421"
2118821188
)
2118921189
);
2119021190
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -21206,10 +21206,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
2120621206
};
2120721207
var internals$jscomp$inline_2485 = {
2120821208
bundleType: 0,
21209-
version: "19.3.0-native-fb-306a01b4-20260420",
21209+
version: "19.3.0-native-fb-94643c3b-20260421",
2121021210
rendererPackageName: "react-dom",
2121121211
currentDispatcherRef: ReactSharedInternals,
21212-
reconcilerVersion: "19.3.0-native-fb-306a01b4-20260420",
21212+
reconcilerVersion: "19.3.0-native-fb-94643c3b-20260421",
2121321213
getLaneLabelMap: function () {
2121421214
for (
2121521215
var map = new Map(), lane = 1, index$346 = 0;
@@ -21485,7 +21485,7 @@ exports.useFormState = function (action, initialState, permalink) {
2148521485
exports.useFormStatus = function () {
2148621486
return ReactSharedInternals.H.useHostTransitionStatus();
2148721487
};
21488-
exports.version = "19.3.0-native-fb-306a01b4-20260420";
21488+
exports.version = "19.3.0-native-fb-94643c3b-20260421";
2148921489
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2149021490
"function" ===
2149121491
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)