Using default framelength (Fixed IOS Crashes) #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DeepakM02
commented
Oct 18, 2021
DeepakM02
commented
- Prevent app crashing
- Using default frame length
DeepakM02
changed the title
safaiyeh
reviewed
Nov 30, 2021
ios/Voice/Voice.m
Outdated
| @@ -224,7 +225,7 @@ - (void) setupAndStartRecognizing:(NSString*)localeStr { | |||
| [mixer installTapOnBus:0 bufferSize:1024 format:recordingFormat block:^(AVAudioPCMBuffer * _Nonnull buffer, AVAudioTime * _Nonnull when) { | |||
| //Volume Level Metering | |||
| //Buffer frame can be reduced, if you need more output values | |||
| [buffer setFrameLength: buffer.frameCapacity]; | |||
| // [buffer setFrameLength: buffer.frameCapacity]; | |||
There was a problem hiding this comment.
Should we make this a prop? so people can customize
There was a problem hiding this comment.
@safaiyeh Do we need to set framelength?
There was a problem hiding this comment.
Gotcha, checked the previous commits looks like we don't need it. Lets clean up the code and delete the line & comments
|
Thanks @DeepakM02 left a couple comments |
clear logs and comments
|
@safaiyeh you can review this |
This was referenced Mar 11, 2022
Open
safaiyeh
pushed a commit
that referenced
this pull request
Mar 13, 2022
## [3.2.3](v3.2.2...v3.2.3) (2022-03-13) ### Bug Fixes * **iOS:** Using default framelength ([#361](#361)) ([8a6086a](8a6086a))
|
🎉 This PR is included in version 3.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
roberto-devp
added a commit
to roberto-devp/voice
that referenced
this pull request
Sep 26, 2024
## [3.2.3](react-native-voice/voice@v3.2.2...v3.2.3) (2022-03-13) ### Bug Fixes * **iOS:** Using default framelength ([#361](react-native-voice/voice#361)) ([8a6086a](react-native-voice/voice@8a6086a))
oleksiy271
pushed a commit
to oleksiy271/voice-recognition
that referenced
this pull request
Oct 31, 2024
## [3.2.3](react-native-voice/voice@v3.2.2...v3.2.3) (2022-03-13) ### Bug Fixes * **iOS:** Using default framelength ([#361](react-native-voice/voice#361)) ([8a6086a](react-native-voice/voice@8a6086a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.