make minute interval work with timepicker default

Author: luancurti

android/src/main/java/com/reactcommunity/rndatetimepicker/RNMinuteIntervals.java

@@ -12,8 +12,4 @@ public final class RNMinuteIntervals {
   public static boolean isValid(Integer interval) {
     return Arrays.asList(MinuteIntervals).contains(interval);
   }
-
-  public static boolean isRadialPickerCompatible(Integer interval) {
-    return MinuteIntervals[0].equals(interval) || MinuteIntervals[1].equals(interval);
-  }
 }

android/src/main/java/com/reactcommunity/rndatetimepicker/RNTimePickerDialogFragment.java

@@ -63,11 +63,7 @@ static TimePickerDialog getDialog(
 
     RNTimePickerDisplay display = RNTimePickerDisplay.DEFAULT;
     if (args != null && args.getString(RNConstants.ARG_DISPLAY, null) != null) {
-      if (RNMinuteIntervals.isRadialPickerCompatible(minuteInterval)) {
-        display = RNTimePickerDisplay.valueOf(args.getString(RNConstants.ARG_DISPLAY).toUpperCase(Locale.US));
-      } else {
-        display = RNTimePickerDisplay.SPINNER;
-      }
+      display = RNTimePickerDisplay.valueOf(args.getString(RNConstants.ARG_DISPLAY).toUpperCase(Locale.US));
     }
 
     if (args != null) {

example/App.js

@@ -55,12 +55,18 @@ const App = () => {
     setDisplay('spinner');
   };
 
-  const showTimepickerWithInterval = () => {
+  const showTimepickerSpinnerWithInterval = () => {
     showMode('time');
     setDisplay('spinner');
     setMinInterval(5);
   };
 
+  const showTimepickerWithInterval = () => {
+    showMode('time');
+    setDisplay('default');
+    setMinInterval(5);
+  };
+
   return (
     <>
       <StatusBar barStyle="dark-content" />
@@ -111,11 +117,18 @@ const App = () => {
                   title="Show time picker!"
                 />
               </View>
+              <View style={styles.button}>
+                <Button
+                  testID="timePickerIntervalButton"
+                  onPress={showTimepickerSpinnerWithInterval}
+                  title="Show time picker spinner (with 5 min interval)!"
+                />
+              </View>
               <View style={styles.button}>
                 <Button
                   testID="timePickerIntervalButton"
                   onPress={showTimepickerWithInterval}
-                  title="Show time picker (with 5 min interval)!"
+                  title="Show time picker default (with 5 min interval)!"
                 />
               </View>
               <View style={styles.button}>

src/timepicker.android.js

@@ -8,8 +8,6 @@
  * @flow strict-local
  */
 import {
-  DISPLAY_DEFAULT,
-  DISPLAY_SPINNER,
   TIME_SET_ACTION,
   DISMISS_ACTION,
   MINUTE_INTERVAL_DEFAULT,
@@ -19,10 +17,6 @@ import {toMilliseconds} from './utils';
 
 import type {TimePickerOptions, DateTimePickerResult} from './types';
 
-const isRadialPickerCompatible = (interval: number) => {
-  return interval === 1 || interval === 5;
-};
-
 export default class TimePickerAndroid {
   /**
    * Opens the standard Android time picker dialog.
@@ -46,9 +40,6 @@ export default class TimePickerAndroid {
   static async open(options: TimePickerOptions): Promise<DateTimePickerResult> {
     toMilliseconds(options, 'value');
     options.minuteInterval = options.minuteInterval || MINUTE_INTERVAL_DEFAULT;
-    options.display = isRadialPickerCompatible(options.minuteInterval)
-      ? options.display || DISPLAY_DEFAULT
-      : DISPLAY_SPINNER;
 
     return NativeModules.RNTimePickerAndroid.open(options);
   }