Skip to content

Commit 83c7689

Browse files
authored
Fix issue 724: unused args (#726)
* Fix issue 724: unused args * Update 02_opt_multi_gpu_ddp.py
1 parent c8c6e78 commit 83c7689

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

ch02/05_bpe-from-scratch/tests/tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def gpt2_files(imported_module):
5858
return paths
5959

6060

61-
def test_tokenizer_training(imported_module, gpt2_files):
61+
def test_tokenizer_training(imported_module):
6262
BPETokenizerSimple = getattr(imported_module, "BPETokenizerSimple", None)
6363
download_file_if_absent = getattr(imported_module, "download_file_if_absent", None)
6464

ch05/10_llm-training-speed/02_opt_multi_gpu_ddp.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ def generate_and_print_sample(model, device, start_context):
312312

313313

314314
def train_model_simple_with_timing(model, train_loader, val_loader, optimizer, device,
315-
num_epochs, eval_freq, eval_iter, start_context, tokenizer):
315+
num_epochs, eval_freq, eval_iter, start_context):
316316
train_losses, val_losses, track_tokens = [], [], []
317317
total_tokens, global_step, last_tokens = 0, -1, 0
318318

@@ -524,8 +524,6 @@ def main(gpt_config, settings, rank, world_size):
524524
# Train model
525525
##############################
526526

527-
tokenizer = tiktoken.get_encoding("gpt2")
528-
529527
train_losses, val_losses, tokens_seen = train_model_simple_with_timing(
530528
model=model,
531529
train_loader=train_loader,
@@ -536,7 +534,6 @@ def main(gpt_config, settings, rank, world_size):
536534
eval_freq=5,
537535
eval_iter=1,
538536
start_context="Every effort moves you",
539-
tokenizer=tokenizer
540537
)
541538

542539
# NEW: Clean up distributed processes

ch06/01_main-chapter-code/gpt_class_finetune.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ def evaluate_model(model, train_loader, val_loader, device, eval_iter):
175175

176176

177177
def train_classifier_simple(model, train_loader, val_loader, optimizer, device, num_epochs,
178-
eval_freq, eval_iter, tokenizer):
178+
eval_freq, eval_iter):
179179
# Initialize lists to track losses and tokens seen
180180
train_losses, val_losses, train_accs, val_accs = [], [], [], []
181181
examples_seen, global_step = 0, -1
@@ -408,7 +408,6 @@ def plot_values(epochs_seen, examples_seen, train_values, val_values, label="los
408408
train_losses, val_losses, train_accs, val_accs, examples_seen = train_classifier_simple(
409409
model, train_loader, val_loader, optimizer, device,
410410
num_epochs=num_epochs, eval_freq=50, eval_iter=5,
411-
tokenizer=tokenizer
412411
)
413412

414413
end_time = time.time()

0 commit comments

Comments
 (0)