Skip to content

Commit 670f7a4

Browse files
authored
- added (missing) Gemma3 bullet point in parent folder's readme.md (#788)
- typo in nbs
1 parent 4a84cfc commit 670f7a4

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

ch05/12_gemma3/standalone-gemma3-plus-kvcache.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@
427427
},
428428
{
429429
"cell_type": "code",
430-
"execution_count": 9,
430+
"execution_count": null,
431431
"id": "e88de3e3-9f07-42cc-816b-28dbd46e96c4",
432432
"metadata": {
433433
"id": "e88de3e3-9f07-42cc-816b-28dbd46e96c4"
@@ -451,7 +451,7 @@
451451
" self.cfg = cfg\n",
452452
" self.current_pos = 0 # Track current position in KV cache\n",
453453
"\n",
454-
" # Reusuable utilities\n",
454+
" # Reusable utilities\n",
455455
" cos_local, sin_local = compute_rope_params(\n",
456456
" head_dim=cfg[\"head_dim\"],\n",
457457
" theta_base=cfg[\"rope_local_base\"],\n",

ch05/12_gemma3/standalone-gemma3.ipynb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@
386386
},
387387
{
388388
"cell_type": "code",
389-
"execution_count": 16,
389+
"execution_count": null,
390390
"id": "e88de3e3-9f07-42cc-816b-28dbd46e96c4",
391391
"metadata": {
392392
"id": "e88de3e3-9f07-42cc-816b-28dbd46e96c4"
@@ -409,7 +409,7 @@
409409
" self.out_head = nn.Linear(cfg[\"emb_dim\"], cfg[\"vocab_size\"], bias=False, dtype=cfg[\"dtype\"])\n",
410410
" self.cfg = cfg\n",
411411
"\n",
412-
" # Reusuable utilities \n",
412+
" # Reusable utilities \n",
413413
" cos_local, sin_local = compute_rope_params(\n",
414414
" head_dim=cfg[\"head_dim\"],\n",
415415
" theta_base=cfg[\"rope_local_base\"],\n",
@@ -1176,7 +1176,7 @@
11761176
"provenance": []
11771177
},
11781178
"kernelspec": {
1179-
"display_name": "Python 3 (ipykernel)",
1179+
"display_name": ".venv",
11801180
"language": "python",
11811181
"name": "python3"
11821182
},
@@ -1190,7 +1190,7 @@
11901190
"name": "python",
11911191
"nbconvert_exporter": "python",
11921192
"pygments_lexer": "ipython3",
1193-
"version": "3.10.16"
1193+
"version": "3.12.6"
11941194
}
11951195
},
11961196
"nbformat": 4,

ch05/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- [09_extending-tokenizers](09_extending-tokenizers) contains a from-scratch implementation of the GPT-2 BPE tokenizer
1919
- [10_llm-training-speed](10_llm-training-speed) shows PyTorch performance tips to improve the LLM training speed
2020
- [11_qwen3](11_qwen3) A from-scratch implementation of Qwen3 0.6B and Qwen3 30B-A3B (Mixture-of-Experts) including code to load the pretrained weights of the base, reasoning, and coding model variants
21+
- [12_gemma3](12_gemma3) A from-scratch implementation of Gemma 3 270M and alternative with KV cache, including code to load the pretrained weights
2122

2223

2324

0 commit comments

Comments
 (0)