Review feedback

Author: KyleFromNVIDIA

.pre-commit-hooks.yaml

@@ -5,3 +5,4 @@
     language: python
     files: "dependencies.yaml"
     pass_filenames: false
+    args: [-Wunused-dependencies, -Werror]

src/rapids_dependency_file_generator/_rapids_dependency_file_validator.py

@@ -47,4 +47,4 @@ def validate_dependencies(dependencies: dict[str, typing.Any]) -> None:
         i for file_config in dependencies["files"].values() for i in file_config["includes"]
     )
     for dep in sorted(unused_dependency_sets):
-        warnings.warn(f'Dependency set "{dep}" is unused.', UnusedDependencySetWarning)
+        warnings.warn(f'Dependency set "{dep}" is not referred to anywhere in "files:"', UnusedDependencySetWarning)

tests/test_cli.py

@@ -1,6 +1,11 @@
+import contextlib
+import os.path
+from textwrap import dedent
+
 import pytest
 
-from rapids_dependency_file_generator._cli import generate_matrix, validate_args
+from rapids_dependency_file_generator._cli import generate_matrix, main, validate_args
+from rapids_dependency_file_generator._rapids_dependency_file_validator import UnusedDependencySetWarning
 
 
 def test_generate_matrix():
@@ -181,3 +186,44 @@ def test_validate_args():
 
     args = validate_args(["--version"])
     assert args.version
+
+
+@pytest.mark.parametrize(
+    ["extra_args", "context"],
+    [
+        (
+            [],
+            contextlib.nullcontext(),
+        ),
+        (
+            ["-Werror"],
+            contextlib.nullcontext(),
+        ),
+        (
+            ["-Wunused-dependencies"],
+            pytest.warns(UnusedDependencySetWarning),
+        ),
+        (
+            ["-Wunused-dependencies", "-Werror"],
+            pytest.raises(UnusedDependencySetWarning),
+        ),
+    ],
+)
+def test_warnings(tmp_path, extra_args, context):
+    config_file = os.path.join(tmp_path, "dependencies.yaml")
+    with open(config_file, "w") as f:
+        f.write(dedent("""
+        files:
+          all:
+            output: conda
+            includes: [a]
+        channels: []
+        dependencies:
+          a:
+            common: []
+          b:
+            common: []
+        """))
+
+    with context:
+        main(["--config", config_file, *extra_args])

tests/test_rapids_dependency_file_validator.py

@@ -29,5 +29,5 @@ def test_validate_dependencies_warn_on_unused_deps():
         })
 
     assert len(warnings) == 2
-    assert warnings[0].message.args[0] == 'Dependency set "c" is unused.'
-    assert warnings[1].message.args[0] == 'Dependency set "d" is unused.'
+    assert warnings[0].message.args[0] == 'Dependency set "c" is not referred to anywhere in "files:"'
+    assert warnings[1].message.args[0] == 'Dependency set "d" is not referred to anywhere in "files:"'