Skip to content

Commit 94c6ee4

Browse files
authored
pip devcontainers: use UCX 1.17, prefer system installation (#4792)
Contributes to rapidsai/build-planning#118 Proposes the following changes for pip devcontainers: * use UCX 1.17 (ref: rapidsai/cugraph-gnn#79 (comment)) * prefer system installation of ucx to the one provided by the `libucx-cu{11,12}` wheels (ref: rapidsai/devcontainers#421 (comment)) And one other related change: * skip most CI when a PR only changes files in the `.devcontainer/` directory (this was incorrectly spelled `.devcontainers/` before) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #4792
1 parent 48b73e2 commit 94c6ee4

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ ARG PYTHON_PACKAGE_MANAGER=conda
66
FROM ${BASE} as pip-base
77

88
ENV DEFAULT_VIRTUAL_ENV=rapids
9+
ENV RAPIDS_LIBUCX_PREFER_SYSTEM_LIBRARY=true
910

1011
RUN apt update -y \
1112
&& DEBIAN_FRONTEND=noninteractive apt install -y \

.devcontainer/cuda11.8-pip/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"args": {
66
"CUDA": "11.8",
77
"PYTHON_PACKAGE_MANAGER": "pip",
8-
"BASE": "rapidsai/devcontainers:25.02-cpp-cuda11.8-ucx1.15.0-openmpi-ubuntu22.04"
8+
"BASE": "rapidsai/devcontainers:25.02-cpp-cuda11.8-ucx1.17.0-openmpi-ubuntu22.04"
99
}
1010
},
1111
"runArgs": [

.github/workflows/pr.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
files_yaml: |
5050
test_cpp:
5151
- '**'
52-
- '!.devcontainers/**'
52+
- '!.devcontainer/**'
5353
- '!CONTRIBUTING.md'
5454
- '!README.md'
5555
- '!docs/**'
@@ -60,13 +60,13 @@ jobs:
6060
- '!readme_pages/**'
6161
test_notebooks:
6262
- '**'
63-
- '!.devcontainers/**'
63+
- '!.devcontainer/**'
6464
- '!CONTRIBUTING.md'
6565
- '!README.md'
6666
- '!docs/**'
6767
test_python:
6868
- '**'
69-
- '!.devcontainers/**'
69+
- '!.devcontainer/**'
7070
- '!CONTRIBUTING.md'
7171
- '!README.md'
7272
- '!docs/**'

0 commit comments

Comments
 (0)