Add auto detect ncurc tests. Minor cleanup.

Author: raineorshine

src/bin/cli.ts

@@ -120,7 +120,7 @@ ${chalk.dim.underline(
 
   // load .ncurc
   // Do not load when global option is set
-  // Do not load when tests are running (an be overridden if configFilePath is set explicitly, or --mergeConfig option specified)
+  // Do not load when tests are running (can be overridden if configFilePath is set explicitly, or --mergeConfig option specified)
   const rcResult =
     !programOpts.global && (!process.env.NCU_TESTS || configFilePath || mergeConfig)
       ? await getNcuRc({ configFileName, configFilePath, packageFile, color })

src/lib/findPackage.ts

@@ -36,7 +36,9 @@ async function findPackage(options: Options) {
           `No ${pkgFileName}`,
         )}\n\nPlease add a ${pkgFileName} to the current directory, specify the ${chalk.cyan(
           '--packageFile',
-        )} or ${chalk.cyan('--packageData')} options, or pipe a ${pkgFileName} to stdin.`,
+        )} or ${chalk.cyan('--packageData')} options, or pipe a ${pkgFileName} to stdin and specify ${chalk.cyan(
+          '--stdin',
+        )}.`,
       )
     }
 

test/rc-config.test.ts

@@ -133,4 +133,38 @@ describe('rc-config', () => {
       await fs.rm(tempDir, { recursive: true, force: true })
     }
   })
+
+  it('auto detect .ncurc.json', async () => {
+    const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'npm-check-updates-'))
+    const configFile = path.join(tempDir, '.ncurc.json')
+    const pkgFile = path.join(tempDir, 'package.json')
+    await fs.writeFile(configFile, '{"filter": "ncu-test-v2"}', 'utf-8')
+    await fs.writeFile(pkgFile, '{ "dependencies": { "ncu-test-v2": "1.0.0", "ncu-test-tag": "0.1.0" } }', 'utf-8')
+    try {
+      // awkwardly, we have to set mergeConfig to enable autodetecting the rcconfig because otherwise it is explicitly disabled for tests
+      const text = await spawn('node', [bin, '--mergeConfig'], { cwd: tempDir })
+      // On OSX tempDir is /var/folders/cb/12345, but npm-check-updates recieves /private/var/folders/cb/12345 (maybe symlink?).
+      // Therefore, ignore any directories prepended to the config file path.
+      text.should.match(new RegExp(`Using config file ([^\n]*)?${configFile}`))
+    } finally {
+      await fs.rm(tempDir, { recursive: true, force: true })
+    }
+  })
+
+  it('auto detect .ncurc.cjs', async () => {
+    const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'npm-check-updates-'))
+    const configFile = path.join(tempDir, '.ncurc.cjs')
+    const pkgFile = path.join(tempDir, 'package.json')
+    await fs.writeFile(configFile, 'module.exports = { "filter": "ncu-test-v2" }', 'utf-8')
+    await fs.writeFile(pkgFile, '{ "dependencies": { "ncu-test-v2": "1.0.0", "ncu-test-tag": "0.1.0" } }', 'utf-8')
+    try {
+      // awkwardly, we have to set mergeConfig to enable autodetecting the rcconfig because otherwise it is explicitly disabled for tests
+      const text = await spawn('node', [bin, '--mergeConfig'], { cwd: tempDir })
+      // On OSX tempDir is /var/folders/cb/12345, but npm-check-updates recieves /private/var/folders/cb/12345 (maybe symlink?).
+      // Therefore, ignore any directories prepended to the config file path.
+      text.should.match(new RegExp(`Using config file ([^\n]*)?${configFile}`))
+    } finally {
+      await fs.rm(tempDir, { recursive: true, force: true })
+    }
+  })
 })