Improve error handling in service discovery tests

- Replace `AssertionFailedError` with `fail` from JUnit across test files for consistency and clarity.
- Enhance test failure messages with detailed error descriptions for better debugging.

Author: gastaldi

service-discovery/stork-custom/src/test/java/io/quarkus/ts/stork/custom/StorkCustomServiceDiscoveryAndLoadBalancerIT.java

@@ -4,6 +4,7 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.greaterThanOrEqualTo;
 import static org.hamcrest.Matchers.is;
+import static org.junit.jupiter.api.Assertions.fail;
 
 import java.io.IOException;
 import java.net.ServerSocket;
@@ -20,8 +21,6 @@
 import io.quarkus.test.services.QuarkusApplication;
 import io.restassured.response.ValidatableResponse;
 
-import junit.framework.AssertionFailedError;
-
 @QuarkusScenario
 @Tag("QUARKUS-1413")
 public class StorkCustomServiceDiscoveryAndLoadBalancerIT {
@@ -82,7 +81,7 @@ protected static String getAvailablePort() {
         try (ServerSocket socket = new ServerSocket(0)) {
             return String.valueOf(socket.getLocalPort());
         } catch (IOException e) {
-            throw new AssertionFailedError();
+            fail("Unable to find available port", e);
         }
     }
 }

service-discovery/stork/src/test/java/io/quarkus/ts/stork/AbstractCommonTestCases.java

@@ -1,5 +1,7 @@
 package io.quarkus.ts.stork;
 
+import static org.junit.jupiter.api.Assertions.fail;
+
 import java.io.IOException;
 import java.net.ServerSocket;
 
@@ -8,8 +10,6 @@
 import io.quarkus.test.bootstrap.RestService;
 import io.restassured.response.ValidatableResponse;
 
-import junit.framework.AssertionFailedError;
-
 public class AbstractCommonTestCases {
 
     public static final String PREFIX = "ping-";
@@ -29,7 +29,7 @@ public static String getAvailablePort() {
         try (ServerSocket socket = new ServerSocket(0)) {
             return String.valueOf(socket.getLocalPort());
         } catch (IOException e) {
-            throw new AssertionFailedError();
+            fail("Unable to find available port", e);
         }
     }
 }