Change new idiom to if/else

adityagandhamal · adityagandhamal · commit 7c5108606bde · 2022-10-04T17:55:46.000+05:30
diff --git a/torchvision/ops/focal_loss.py b/torchvision/ops/focal_loss.py
@@ -34,8 +34,7 @@ def sigmoid_focal_loss(
     # Original implementation from https://github.com/facebookresearch/fvcore/blob/master/fvcore/nn/focal_loss.py
 
     # Check reduction option
-    modes = ["none", "mean", "sum"]
-    if reduction not in modes:
+    if reduction != "none" or reduction != "mean" or reduction != "sum":
         raise ValueError(
             f"Invalid Value for arg 'reduction': '{reduction} \n Supported reduction modes: 'none', 'mean', 'sum'"
         )

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,7 @@ def sigmoid_focal_loss(`
`34`	`34`	`# Original implementation from https://github.com/facebookresearch/fvcore/blob/master/fvcore/nn/focal_loss.py`
`35`	`35`
`36`	`36`	`# Check reduction option`
`37`		`- modes = ["none", "mean", "sum"]`
`38`		`- if reduction not in modes:`
	`37`	`+ if reduction != "none" or reduction != "mean" or reduction != "sum":`
`39`	`38`	`raise ValueError(`
`40`	`39`	`f"Invalid Value for arg 'reduction': '{reduction} \n Supported reduction modes: 'none', 'mean', 'sum'"`
`41`	`40`	`)`