Revert "torchx/runner: log events to torch.monitor (#379)" #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kurman
approved these changes
Jun 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #536 +/- ##
==========================================
+ Coverage 94.75% 94.81% +0.06%
==========================================
Files 65 65
Lines 3949 3937 -12
==========================================
- Hits 3742 3733 -9
+ Misses 207 204 -3
Continue to review full report at Codecov.
|
|
This pull request was exported from Phabricator. Differential Revision: D37432126 |
d4l3k
added a commit
that referenced
this pull request
Jun 24, 2022
Summary: This reverts commit 4b989d5. Importing torch.monitor adds a pretty large dependency on torch which hugely slows down load time in OSS. This accounts for about 340ms of load time. Pull Request resolved: #536 Test Plan: This isn't being used anywhere AFAIK so should be safe to land. Internal has a custom handler. Reviewed By: priyaramani, kurman Differential Revision: D37432126 Pulled By: d4l3k fbshipit-source-id: f38a89a7a4dbbd69e9ba43c130bd31b084c0bb00
Summary: This reverts commit 4b989d5. Importing torch.monitor adds a pretty large dependency on torch which hugely slows down load time in OSS. This accounts for about 340ms of load time. Pull Request resolved: #536 Test Plan: This isn't being used anywhere AFAIK so should be safe to land. Internal has a custom handler. Reviewed By: priyaramani, kurman Differential Revision: D37432126 Pulled By: d4l3k fbshipit-source-id: 410e25744ad26706e35eee8e10f90ef8f94514ee
|
This pull request was exported from Phabricator. Differential Revision: D37432126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4b989d5.
Importing torch.monitor adds a pretty large dependency on torch which hugely slows down load time in OSS.
Test plan:
This isn't being used anywhere AFAIK so should be safe to land. Internal has a custom handler.