Add annotations to torchx

Reviewed By: shannonzhu

Differential Revision: D33968273

fbshipit-source-id: 395c9472c78561e066a572c4d428bdf610258c28

Author: Pyre Bot Jr

torchx/runner/test/api_test.py

@@ -370,7 +370,7 @@ def test_get_schedulers(self, json_dumps_mock: MagicMock, _) -> None:
             runner.run(app, scheduler="local")
             local_sched_mock.submit.called_once_with(app, {})
 
-    def test_run_from_module(self, _) -> None:
+    def test_run_from_module(self, _: str) -> None:
         runner = get_runner(name="test_session")
         app_args = ["--image", "dummy_image", "--script", "test.py"]
         with patch.object(runner, "schedule"), patch.object(

torchx/specs/test/file_linter_test.py

@@ -24,8 +24,7 @@ def _test_empty_fn() -> "AppDef":
 
 
 # Note if the function is moved, the tests need to be updated with new lineno
-# pyre-ignore[3]: Omit return value for testing purposes
-def _test_fn_no_return():
+def _test_fn_no_return() -> None:
     """
     Function description
     """

torchx/util/entrypoints.py

@@ -49,7 +49,7 @@ def load(group: str, name: str, default=None):
 
 # pyre-ignore-all-errors[3, 2]
 def load_group(
-    group: str, default: Optional[Dict[str, Any]] = None, ignore_missing=False
+    group: str, default: Optional[Dict[str, Any]] = None, ignore_missing: bool = False
 ):
     """
     Loads all the entry points specified by ``group`` and returns

torchx/util/types.py

@@ -51,7 +51,9 @@ def _get_key(arg: str, spos: int, kv_delimiter: str = "=") -> str:
     return arg[spos:epos]
 
 
-def _get_value(arg: str, spos: int, kv_delimiter="=", pair_delimiter=",") -> str:
+def _get_value(
+    arg: str, spos: int, kv_delimiter: str = "=", pair_delimiter: str = ","
+) -> str:
     epos: int = spos + 1
     while epos < len(arg) and arg[epos] != kv_delimiter:
         epos += 1