From 7c719c6b08bfe520e6d18dafbdb0121c9c1d1669 Mon Sep 17 00:00:00 2001 From: Eclips4 Date: Sat, 4 Feb 2023 23:58:40 +0200 Subject: [PATCH 1/6] fix types of kwlist and softkwlist --- stdlib/keyword.pyi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/stdlib/keyword.pyi b/stdlib/keyword.pyi index c17c58012fd1..da05ec13a1af 100644 --- a/stdlib/keyword.pyi +++ b/stdlib/keyword.pyi @@ -1,5 +1,5 @@ import sys -from collections.abc import Sequence + if sys.version_info >= (3, 9): __all__ = ["iskeyword", "issoftkeyword", "kwlist", "softkwlist"] @@ -8,8 +8,8 @@ else: def iskeyword(s: str) -> bool: ... -kwlist: Sequence[str] +kwlist: list[str] if sys.version_info >= (3, 9): def issoftkeyword(s: str) -> bool: ... - softkwlist: Sequence[str] + softkwlist: list[str] From ebdc2bcbf75b1d59ff464ee10fd45eacd8e39d2a Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sat, 4 Feb 2023 22:02:43 +0000 Subject: [PATCH 2/6] [pre-commit.ci] auto fixes from pre-commit.com hooks --- stdlib/keyword.pyi | 1 - 1 file changed, 1 deletion(-) diff --git a/stdlib/keyword.pyi b/stdlib/keyword.pyi index da05ec13a1af..884af28918d2 100644 --- a/stdlib/keyword.pyi +++ b/stdlib/keyword.pyi @@ -1,6 +1,5 @@ import sys - if sys.version_info >= (3, 9): __all__ = ["iskeyword", "issoftkeyword", "kwlist", "softkwlist"] else: From 7c6abe9e60fb52d397797547c3299be504db95ac Mon Sep 17 00:00:00 2001 From: Eclips4 Date: Sun, 5 Feb 2023 13:34:19 +0200 Subject: [PATCH 3/6] change types of kwlist & softkwlist to Final[Sequence[str]] --- stdlib/keyword.pyi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/stdlib/keyword.pyi b/stdlib/keyword.pyi index 884af28918d2..acfb98397747 100644 --- a/stdlib/keyword.pyi +++ b/stdlib/keyword.pyi @@ -1,4 +1,5 @@ import sys +from typing import Sequence, Final if sys.version_info >= (3, 9): __all__ = ["iskeyword", "issoftkeyword", "kwlist", "softkwlist"] @@ -7,8 +8,8 @@ else: def iskeyword(s: str) -> bool: ... -kwlist: list[str] +kwlist: Final[Sequence[str]] if sys.version_info >= (3, 9): def issoftkeyword(s: str) -> bool: ... - softkwlist: list[str] + softkwlist: Final[Sequence[str]] From 8743fd647cd223acb0632a2ed36882e2a0bab869 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sun, 5 Feb 2023 11:35:50 +0000 Subject: [PATCH 4/6] [pre-commit.ci] auto fixes from pre-commit.com hooks --- stdlib/keyword.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stdlib/keyword.pyi b/stdlib/keyword.pyi index acfb98397747..41765f11c989 100644 --- a/stdlib/keyword.pyi +++ b/stdlib/keyword.pyi @@ -1,5 +1,5 @@ import sys -from typing import Sequence, Final +from typing import Final, Sequence if sys.version_info >= (3, 9): __all__ = ["iskeyword", "issoftkeyword", "kwlist", "softkwlist"] From 7b9b559f19d4fb1492a790868134da20b3eb47ac Mon Sep 17 00:00:00 2001 From: Alex Waygood Date: Sun, 5 Feb 2023 12:58:39 +0000 Subject: [PATCH 5/6] Fix imports --- stdlib/keyword.pyi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/stdlib/keyword.pyi b/stdlib/keyword.pyi index 41765f11c989..597c8c15bf0a 100644 --- a/stdlib/keyword.pyi +++ b/stdlib/keyword.pyi @@ -1,5 +1,6 @@ import sys -from typing import Final, Sequence +from collections.abc import Sequence +from typing_extensions import Final if sys.version_info >= (3, 9): __all__ = ["iskeyword", "issoftkeyword", "kwlist", "softkwlist"] From 6d1f5454c05b4b469fedcc27501c4d3cc67cfb92 Mon Sep 17 00:00:00 2001 From: Alex Waygood Date: Sun, 5 Feb 2023 13:32:29 +0000 Subject: [PATCH 6/6] Add comments --- stdlib/keyword.pyi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/stdlib/keyword.pyi b/stdlib/keyword.pyi index 597c8c15bf0a..46c386048858 100644 --- a/stdlib/keyword.pyi +++ b/stdlib/keyword.pyi @@ -9,8 +9,13 @@ else: def iskeyword(s: str) -> bool: ... +# a list at runtime, but you're not meant to mutate it; +# type it as a sequence kwlist: Final[Sequence[str]] if sys.version_info >= (3, 9): def issoftkeyword(s: str) -> bool: ... + + # a list at runtime, but you're not meant to mutate it; + # type it as a sequence softkwlist: Final[Sequence[str]]