Skip to content

Add pre-commit config for flake8 #8068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2022
Merged

Add pre-commit config for flake8 #8068

merged 3 commits into from
Jun 14, 2022

Conversation

sirosen
Copy link
Contributor

@sirosen sirosen commented Jun 13, 2022

This makes it easier to lint your own work with pre-commit, but doesn't change the CI config by adding this to the pre-commit.ci skip list.

There's no way to automatically reflect the additional dependencies from the requirements file, so the flake8 plugin list needs to be a verbatim copy.

resolves #7991

Two asides:

  • Sorry this took me so long to put in. I meant to do it right away and got distracted.
  • If there's any discomfort about copying the requirements data, let's just nix this and close Make it easier to run flake8 for contributors #7991 as a wontfix (at least for now). I think it's worth keeping the copy, but I also understand not wanting duplicate configs.

@sirosen
Add pre-commit config for flake8
9aae9ab 
This makes it easier to lint your own work with `pre-commit`, but
doesn't change the CI config by adding this to the pre-commit.ci skip
list.

There's no way to automatically reflect the additional dependencies
from the requirements file, so the flake8 plugin list needs to be a
verbatim copy.

resolves python#7991
srittau
srittau reviewed Jun 13, 2022
View reviewed changes
@sirosen
Add comments to keep flake8 deps in sync
d55aa8b 
Pithy 'must match' comments, in the same style as the existing
comments to this effect.
AlexWaygood
AlexWaygood reviewed Jun 13, 2022
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sirosen! 🎉

@AlexWaygood AlexWaygood merged commit 1991321 into python:master Jun 14, 2022
@sirosen sirosen deleted the flake8-precommit branch June 14, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau left review comments

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it easier to run flake8 for contributors
3 participants
@sirosen @srittau @AlexWaygood