From 228152ceaa694209d682437e5a1061000ecdb675 Mon Sep 17 00:00:00 2001 From: Hardik Prajapati Date: Wed, 6 Oct 2021 19:40:13 +0530 Subject: [PATCH 1/2] ADD: types for ExtensionFileLoader (#4769) --- stdlib/importlib/machinery.pyi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/stdlib/importlib/machinery.pyi b/stdlib/importlib/machinery.pyi index a2e89bb2d8de..a93abf448137 100644 --- a/stdlib/importlib/machinery.pyi +++ b/stdlib/importlib/machinery.pyi @@ -115,3 +115,7 @@ class ExtensionFileLoader(importlib.abc.ExecutionLoader): def __init__(self, name: str, path: importlib.abc._Path) -> None: ... def get_filename(self, name: str | None = ...) -> importlib.abc._Path: ... def get_source(self, fullname: str) -> None: ... + def create_module(self, spec: ModuleSpec) -> types.ModuleType | None: ... + def exec_module(self, module: types.ModuleType) -> None: ... + def is_package(self, fullname: str) -> bool: ... + def get_code(self, fullname: str) -> None: ... From 4e39c150ce6c128561861429b3f6af2cf5856081 Mon Sep 17 00:00:00 2001 From: Hardik Prajapati Date: Wed, 6 Oct 2021 21:01:14 +0530 Subject: [PATCH 2/2] FIX: remove None from create_modules's return type --- stdlib/importlib/machinery.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stdlib/importlib/machinery.pyi b/stdlib/importlib/machinery.pyi index a93abf448137..30194f6f2ad6 100644 --- a/stdlib/importlib/machinery.pyi +++ b/stdlib/importlib/machinery.pyi @@ -115,7 +115,7 @@ class ExtensionFileLoader(importlib.abc.ExecutionLoader): def __init__(self, name: str, path: importlib.abc._Path) -> None: ... def get_filename(self, name: str | None = ...) -> importlib.abc._Path: ... def get_source(self, fullname: str) -> None: ... - def create_module(self, spec: ModuleSpec) -> types.ModuleType | None: ... + def create_module(self, spec: ModuleSpec) -> types.ModuleType: ... def exec_module(self, module: types.ModuleType) -> None: ... def is_package(self, fullname: str) -> bool: ... def get_code(self, fullname: str) -> None: ...