@@ -131,7 +131,7 @@ You should have already :ref:`set up your system <setup>`,
131
131
git commit -m '<message>'
132
132
git push origin <branch-name>
133
133
134
- * If a core developer reviewing your PR pushed one or more commits to your
134
+ * If a core team member reviewing your PR pushed one or more commits to your
135
135
PR branch, then after checking out your branch and before editing, run::
136
136
137
137
git pull origin <branch-name> # pull = fetch + merge
@@ -204,7 +204,7 @@ should do to help ensure that your pull request is accepted.
204
204
205
205
#. **Make sure to follow Python's style guidelines. ** For Python code you
206
206
should follow :PEP: `8 `, and for C code you should follow :PEP: `7 `. If you have
207
- one or two discrepancies those can be fixed by the core developer who merges
207
+ one or two discrepancies those can be fixed by the core team member who merges
208
208
your pull request. But if you have systematic deviations from the style guides
209
209
your pull request will be put on hold until you fix the formatting issues.
210
210
@@ -324,7 +324,7 @@ Furthermore, the first line should not end in a period.
324
324
325
325
If this is not enough detail for a commit, a new paragraph(s) can be added
326
326
to explain in proper depth what has happened (detail should be good enough
327
- that a core developer reading the commit message understands the
327
+ that a core team member reading the commit message understands the
328
328
justification for the change).
329
329
330
330
Check :ref: `the Git bootcamp <accepting-and-merging-a-pr >` for further
@@ -447,7 +447,7 @@ to ask for someone to review your pull request.
447
447
448
448
When someone does manage to find the time to look at your pull request
449
449
they will most likely make comments about how it can be improved
450
- (don't worry, even core developers of Python have their pull requests sent
450
+ (don't worry, even core team members of Python have their pull requests sent
451
451
back to them for changes). It is then expected that you update your
452
452
pull request to address these comments, and the review process will
453
453
thus iterate until a satisfactory solution has emerged.
@@ -514,11 +514,13 @@ Instead of simply "approving" the pull request, leave comments. For example:
514
514
#. Look at any failures in CI on the current PR. See :ref: `"Keeping CI green"
515
515
<keeping-ci-green>` below for simple things you can do to help move the PR forward.
516
516
517
- Dismissing review from another core developer
518
- ---------------------------------------------
517
+ .. _dismissing-review-from-another-core-developer :
519
518
520
- A core developer can dismiss another core developer's review if they confirmed
521
- that the requested changes have been made. When a core developer has assigned
519
+ Dismissing review from another core team member
520
+ -----------------------------------------------
521
+
522
+ A core team member can dismiss another team member's review if they confirmed
523
+ that the requested changes have been made. When a core team member has assigned
522
524
the PR to themselves, then it is a sign that they are actively looking after
523
525
the PR, and their review should not be dismissed.
524
526
@@ -589,7 +591,7 @@ Python is tricky and we simply cannot accept everyone's contributions.
589
591
But if your pull request is merged it will then go into Python's
590
592
:abbr: `VCS ( version control system ) ` to be released
591
593
with the next feature release of Python. It may also be backported to older
592
- versions of Python as a bugfix if the core developer doing the merge believes
594
+ versions of Python as a bugfix if the core team member doing the merge believes
593
595
it is warranted.
594
596
595
597
@@ -598,7 +600,7 @@ Crediting
598
600
599
601
Non-trivial contributions are credited in the ``Misc/ACKS `` file (and, most
600
602
often, in a contribution's news entry as well). You may be
601
- asked to make these edits on the behalf of the core developer who
603
+ asked to make these edits on the behalf of the core team member who
602
604
accepts your pull request.
603
605
604
606
.. _issue tracker : https://github.com/python/cpython/issues
0 commit comments