From 6a168623a83521c04675c5b791906a8291adb947 Mon Sep 17 00:00:00 2001 From: Tom Faulkner Date: Sat, 30 Jun 2018 22:38:38 -0500 Subject: [PATCH 1/2] Update dataclasses.rst Fix example on 30.6.8, add method should receive a list rather than an integer. Current example gives a TypeError. ``` Traceback (most recent call last): File "", line 1, in l += 1 TypeError: 'int' object is not iterable ``` --- Doc/library/dataclasses.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Doc/library/dataclasses.rst b/Doc/library/dataclasses.rst index b26f6422db917a..a692266fcc0cf1 100644 --- a/Doc/library/dataclasses.rst +++ b/Doc/library/dataclasses.rst @@ -536,8 +536,8 @@ Mutable default values o1 = C() o2 = C() - o1.add(1) - o2.add(2) + o1.add([1]) + o2.add([2]) assert o1.x == [1, 2] assert o1.x is o2.x From 78c036cfae46ce9cb72f8ce5ff4e779d3844c286 Mon Sep 17 00:00:00 2001 From: Tom Faulkner Date: Tue, 10 Jul 2018 20:08:16 -0500 Subject: [PATCH 2/2] Update dataclasses.rst Change function to append rather than add lists. --- Doc/library/dataclasses.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Doc/library/dataclasses.rst b/Doc/library/dataclasses.rst index a692266fcc0cf1..9e3c792fd106c7 100644 --- a/Doc/library/dataclasses.rst +++ b/Doc/library/dataclasses.rst @@ -532,12 +532,12 @@ Mutable default values class C: x = [] def add(self, element): - self.x += element + self.x.append(element) o1 = C() o2 = C() - o1.add([1]) - o2.add([2]) + o1.add(1) + o2.add(2) assert o1.x == [1, 2] assert o1.x is o2.x