From 6f6bfa5c3fa28fefdc9069a88492f81fc595a30f Mon Sep 17 00:00:00 2001 From: sobolevn Date: Tue, 23 Nov 2021 12:36:55 +0300 Subject: [PATCH] bpo-45878: convert `try/except` to `self.assertRaises` in `Lib/ctypes/test/test_functions.py` --- Lib/ctypes/test/test_functions.py | 18 ++++-------------- .../2021-11-23-12-36-21.bpo-45878.eOs_Mp.rst | 2 ++ 2 files changed, 6 insertions(+), 14 deletions(-) create mode 100644 Misc/NEWS.d/next/Tests/2021-11-23-12-36-21.bpo-45878.eOs_Mp.rst diff --git a/Lib/ctypes/test/test_functions.py b/Lib/ctypes/test/test_functions.py index c5456ba107ae3a..f9e92e1cc6b068 100644 --- a/Lib/ctypes/test/test_functions.py +++ b/Lib/ctypes/test/test_functions.py @@ -35,34 +35,24 @@ def test_mro(self): # wasn't checked, and it even crashed Python. # Found by Greg Chapman. - try: + with self.assertRaises(TypeError): class X(object, Array): _length_ = 5 _type_ = "i" - except TypeError: - pass - from _ctypes import _Pointer - try: + with self.assertRaises(TypeError): class X(object, _Pointer): pass - except TypeError: - pass from _ctypes import _SimpleCData - try: + with self.assertRaises(TypeError): class X(object, _SimpleCData): _type_ = "i" - except TypeError: - pass - try: + with self.assertRaises(TypeError): class X(object, Structure): _fields_ = [] - except TypeError: - pass - @need_symbol('c_wchar') def test_wchar_parm(self): diff --git a/Misc/NEWS.d/next/Tests/2021-11-23-12-36-21.bpo-45878.eOs_Mp.rst b/Misc/NEWS.d/next/Tests/2021-11-23-12-36-21.bpo-45878.eOs_Mp.rst new file mode 100644 index 00000000000000..fca90ef46981b7 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2021-11-23-12-36-21.bpo-45878.eOs_Mp.rst @@ -0,0 +1,2 @@ +Test ``Lib/ctypes/test/test_functions.py::test_mro`` now uses +``self.assertRaises`` instead of ``try/except``.