From 1835fbb1ee3ff008bf580ea35bbcf5c7a646405e Mon Sep 17 00:00:00 2001 From: Chris Eibl <138194463+chris-eibl@users.noreply.github.com> Date: Sat, 5 Apr 2025 09:31:28 +0200 Subject: [PATCH 1/4] Fix GENERATE_DEBUG_SECTION for clangcl on Windows --- Include/internal/pycore_debug_offsets.h | 4 +++- Modules/_asynciomodule.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Include/internal/pycore_debug_offsets.h b/Include/internal/pycore_debug_offsets.h index 124b104e4ba8ae..b280633c9ef679 100644 --- a/Include/internal/pycore_debug_offsets.h +++ b/Include/internal/pycore_debug_offsets.h @@ -23,7 +23,9 @@ extern "C" { declaration \ _GENERATE_DEBUG_SECTION_LINUX(name) -#if defined(MS_WINDOWS) && !defined(__clang__) +// Please note that section names are truncated to eight bytes +// on Windows! +#if defined(MS_WINDOWS) #define _GENERATE_DEBUG_SECTION_WINDOWS(name) \ _Pragma(Py_STRINGIFY(section(Py_STRINGIFY(name), read, write))) \ __declspec(allocate(Py_STRINGIFY(name))) diff --git a/Modules/_asynciomodule.c b/Modules/_asynciomodule.c index d938955e8cb0e3..b32db3a277cf4a 100644 --- a/Modules/_asynciomodule.c +++ b/Modules/_asynciomodule.c @@ -116,7 +116,7 @@ typedef struct _Py_AsyncioModuleDebugOffsets { } asyncio_thread_state; } Py_AsyncioModuleDebugOffsets; -GENERATE_DEBUG_SECTION(AsyncioDebug, Py_AsyncioModuleDebugOffsets AsyncioDebug) +GENERATE_DEBUG_SECTION(AsyncioDebug, Py_AsyncioModuleDebugOffsets _AsyncioDebug) = {.asyncio_task_object = { .size = sizeof(TaskObj), .task_name = offsetof(TaskObj, task_name), From fc18d45dec0e53c3bd20d9dfe037f2943a537880 Mon Sep 17 00:00:00 2001 From: Chris Eibl <138194463+chris-eibl@users.noreply.github.com> Date: Sat, 5 Apr 2025 09:32:38 +0200 Subject: [PATCH 2/4] Trigger Windows tail-call CI --- .github/workflows/tail-call.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tail-call.yml b/.github/workflows/tail-call.yml index 572ff45e51ef00..0be8ef218b91f9 100644 --- a/.github/workflows/tail-call.yml +++ b/.github/workflows/tail-call.yml @@ -1,3 +1,4 @@ +# TODO: remove - just triggering Windows tail-call CI name: Tail calling interpreter on: pull_request: From 7c4dcbe6adc1543af1ad92ee6291db90c3a6cba5 Mon Sep 17 00:00:00 2001 From: Chris Eibl <138194463+chris-eibl@users.noreply.github.com> Date: Sat, 5 Apr 2025 10:02:21 +0200 Subject: [PATCH 3/4] Revert "Trigger Windows tail-call CI" This reverts commit fc18d45dec0e53c3bd20d9dfe037f2943a537880. --- .github/workflows/tail-call.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tail-call.yml b/.github/workflows/tail-call.yml index 0be8ef218b91f9..572ff45e51ef00 100644 --- a/.github/workflows/tail-call.yml +++ b/.github/workflows/tail-call.yml @@ -1,4 +1,3 @@ -# TODO: remove - just triggering Windows tail-call CI name: Tail calling interpreter on: pull_request: From 565366a3b59960d7dbad25e84c18ef938064c2e6 Mon Sep 17 00:00:00 2001 From: Chris Eibl <138194463+chris-eibl@users.noreply.github.com> Date: Sat, 5 Apr 2025 10:14:39 +0200 Subject: [PATCH 4/4] update ignored.tsv --- Tools/c-analyzer/cpython/ignored.tsv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tools/c-analyzer/cpython/ignored.tsv b/Tools/c-analyzer/cpython/ignored.tsv index 18e543ab33bb16..14dc5007b65861 100644 --- a/Tools/c-analyzer/cpython/ignored.tsv +++ b/Tools/c-analyzer/cpython/ignored.tsv @@ -56,7 +56,7 @@ Python/pyhash.c - _Py_HashSecret - Python/parking_lot.c - buckets - ## data needed for introspecting asyncio state from debuggers and profilers -Modules/_asynciomodule.c - AsyncioDebug - +Modules/_asynciomodule.c - _AsyncioDebug - ##################################