Skip to content

Commit cbfcc67

Browse files
bpo-41907: [Enum] fix format() behavior for IntFlag (GH-22497) (GH-23704)
(cherry picked from commit 37440ee)
1 parent b947b30 commit cbfcc67

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

Lib/enum.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -663,7 +663,7 @@ def __format__(self, format_spec):
663663
# the value
664664

665665
# pure Enum branch, or branch with __str__ explicitly overridden
666-
str_overridden = type(self).__str__ != Enum.__str__
666+
str_overridden = type(self).__str__ not in (Enum.__str__, Flag.__str__)
667667
if self._member_type_ is object or str_overridden:
668668
cls = str
669669
val = str(self)

Lib/test/test_enum.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -569,12 +569,15 @@ def hello(self):
569569
class Test1Enum(MyMethodEnum, int, MyStrEnum):
570570
One = 1
571571
Two = 2
572+
self.assertTrue(Test1Enum._member_type_ is int)
572573
self.assertEqual(str(Test1Enum.One), 'MyStr')
574+
self.assertEqual(format(Test1Enum.One, ''), 'MyStr')
573575
#
574576
class Test2Enum(MyStrEnum, MyMethodEnum):
575577
One = 1
576578
Two = 2
577579
self.assertEqual(str(Test2Enum.One), 'MyStr')
580+
self.assertEqual(format(Test1Enum.One, ''), 'MyStr')
578581

579582
def test_inherited_data_type(self):
580583
class HexInt(int):
@@ -2172,6 +2175,11 @@ def test_repr(self):
21722175
self.assertEqual(repr(~(Open.RO | Open.CE)), '<Open.AC: 3>')
21732176
self.assertEqual(repr(~(Open.WO | Open.CE)), '<Open.RW: 2>')
21742177

2178+
def test_format(self):
2179+
Perm = self.Perm
2180+
self.assertEqual(format(Perm.R, ''), 'Perm.R')
2181+
self.assertEqual(format(Perm.R | Perm.X, ''), 'Perm.R|X')
2182+
21752183
def test_or(self):
21762184
Perm = self.Perm
21772185
for i in Perm:
@@ -2504,6 +2512,7 @@ class Color(IntFlag):
25042512

25052513
def test_type(self):
25062514
Perm = self.Perm
2515+
self.assertTrue(Perm._member_type_ is int)
25072516
Open = self.Open
25082517
for f in Perm:
25092518
self.assertTrue(isinstance(f, Perm))
@@ -2583,6 +2592,11 @@ def test_repr(self):
25832592
self.assertEqual(repr(~(Open.WO | Open.CE)), '<Open.RW: -524290>')
25842593
self.assertEqual(repr(Open(~4)), '<Open.CE|AC|RW|WO: -5>')
25852594

2595+
def test_format(self):
2596+
Perm = self.Perm
2597+
self.assertEqual(format(Perm.R, ''), '4')
2598+
self.assertEqual(format(Perm.R | Perm.X, ''), '5')
2599+
25862600
def test_or(self):
25872601
Perm = self.Perm
25882602
for i in Perm:
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
fix `format()` behavior for `IntFlag`

0 commit comments

Comments
 (0)