Skip to content

Commit 9efdf58

Browse files
committed
Fix exit code for unittest in Python 3.12
Increase the number of running test only if it hasn't been skipped.
1 parent 3f9bc86 commit 9efdf58

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

Lib/test/test_unittest/test_discovery.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@ def _get_module_from_name(name):
572572
result = unittest.TestResult()
573573
suite.run(result)
574574
self.assertEqual(len(result.skipped), 1)
575-
self.assertEqual(result.testsRun, 1)
575+
self.assertEqual(result.testsRun, 0)
576576
self.assertEqual(import_calls, ['my_package'])
577577

578578
# Check picklability

Lib/test/test_unittest/test_skipping.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,16 +103,16 @@ def test_dont_skip(self): pass
103103
result = LoggingResult(events)
104104
self.assertIs(suite.run(result), result)
105105
self.assertEqual(len(result.skipped), 1)
106-
expected = ['startTest', 'addSkip', 'stopTest',
107-
'startTest', 'addSuccess', 'stopTest']
106+
expected = ['addSkip', 'stopTest', 'startTest',
107+
'addSuccess', 'stopTest']
108108
self.assertEqual(events, expected)
109-
self.assertEqual(result.testsRun, 2)
109+
self.assertEqual(result.testsRun, 1)
110110
self.assertEqual(result.skipped, [(test_do_skip, "testing")])
111111
self.assertTrue(result.wasSuccessful())
112112

113113
events = []
114114
result = test_do_skip.run()
115-
self.assertEqual(events, ['startTestRun', 'startTest', 'addSkip',
115+
self.assertEqual(events, ['startTestRun', 'addSkip',
116116
'stopTest', 'stopTestRun'])
117117
self.assertEqual(result.skipped, [(test_do_skip, "testing")])
118118

@@ -135,13 +135,13 @@ def test_1(self):
135135
test = Foo("test_1")
136136
suite = unittest.TestSuite([test])
137137
self.assertIs(suite.run(result), result)
138-
self.assertEqual(events, ['startTest', 'addSkip', 'stopTest'])
138+
self.assertEqual(events, ['addSkip', 'stopTest'])
139139
self.assertEqual(result.skipped, [(test, "testing")])
140140
self.assertEqual(record, [])
141141

142142
events = []
143143
result = test.run()
144-
self.assertEqual(events, ['startTestRun', 'startTest', 'addSkip',
144+
self.assertEqual(events, ['startTestRun', 'addSkip',
145145
'stopTest', 'stopTestRun'])
146146
self.assertEqual(result.skipped, [(test, "testing")])
147147
self.assertEqual(record, [])

Lib/unittest/case.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,6 @@ def run(self, result=None):
606606
else:
607607
stopTestRun = None
608608

609-
result.startTest(self)
610609
try:
611610
testMethod = getattr(self, self._testMethodName)
612611
if (getattr(self.__class__, "__unittest_skip__", False) or
@@ -617,6 +616,9 @@ def run(self, result=None):
617616
_addSkip(result, self, skip_why)
618617
return result
619618

619+
# Increase the number of running test only if it hasn't been skipped
620+
result.startTest(self)
621+
620622
expecting_failure = (
621623
getattr(self, "__unittest_expecting_failure__", False) or
622624
getattr(testMethod, "__unittest_expecting_failure__", False)

0 commit comments

Comments
 (0)