Skip to content

Commit 96dbd9f

Browse files
Refactor: replace query with parameter
Pass state as arg to treebuilder_handle_pi()
1 parent 0a4b852 commit 96dbd9f

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

Modules/_elementtree.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2782,13 +2782,13 @@ treebuilder_handle_comment(elementtreestate *st, TreeBuilderObject *self,
27822782
}
27832783

27842784
LOCAL(PyObject*)
2785-
treebuilder_handle_pi(TreeBuilderObject* self, PyObject* target, PyObject* text)
2785+
treebuilder_handle_pi(elementtreestate *st, TreeBuilderObject *self,
2786+
PyObject *target, PyObject *text)
27862787
{
27872788
PyObject* pi;
27882789
PyObject* this;
27892790
PyObject* stack[2] = {target, text};
27902791

2791-
elementtreestate *st = ET_STATE_GLOBAL;
27922792
if (treebuilder_flush_data(st, self) < 0) {
27932793
return NULL;
27942794
}
@@ -2921,7 +2921,8 @@ _elementtree_TreeBuilder_pi_impl(TreeBuilderObject *self, PyObject *target,
29212921
PyObject *text)
29222922
/*[clinic end generated code: output=21eb95ec9d04d1d9 input=349342bd79c35570]*/
29232923
{
2924-
return treebuilder_handle_pi(self, target, text);
2924+
elementtreestate *st = ET_STATE_GLOBAL;
2925+
return treebuilder_handle_pi(st, self, target, text);
29252926
}
29262927

29272928
LOCAL(PyObject*)
@@ -3507,7 +3508,7 @@ expat_pi_handler(XMLParserObject* self, const XML_Char* target_in,
35073508
data = PyUnicode_DecodeUTF8(data_in, strlen(data_in), "strict");
35083509
if (!data)
35093510
goto error;
3510-
res = treebuilder_handle_pi(target, pi_target, data);
3511+
res = treebuilder_handle_pi(st, target, pi_target, data);
35113512
Py_XDECREF(res);
35123513
Py_DECREF(data);
35133514
Py_DECREF(pi_target);

0 commit comments

Comments
 (0)