Move sqlite3.InternalError to global state

Author: Erlend E. Aasland

Modules/_sqlite/connection.c

@@ -196,7 +196,7 @@ pysqlite_connection_init(pysqlite_Connection *self, PyObject *args,
     self->DataError             = pysqlite_DataError;
     self->OperationalError      = pysqlite_OperationalError;
     self->IntegrityError        = pysqlite_IntegrityError;
-    self->InternalError         = pysqlite_InternalError;
+    self->InternalError         = state->InternalError;
     self->ProgrammingError      = pysqlite_ProgrammingError;
     self->NotSupportedError     = pysqlite_NotSupportedError;
 

Modules/_sqlite/module.c

@@ -43,7 +43,6 @@ module _sqlite3
 
 /* static objects at module-level */
 
-PyObject *pysqlite_InternalError = NULL;
 PyObject *pysqlite_OperationalError = NULL;
 PyObject *pysqlite_ProgrammingError = NULL;
 PyObject *pysqlite_IntegrityError = NULL;
@@ -416,7 +415,7 @@ PyMODINIT_FUNC PyInit__sqlite3(void)
     ADD_EXCEPTION(module, "DatabaseError", state->DatabaseError, state->Error);
 
     /* DatabaseError subclasses */
-    ADD_EXCEPTION(module, "InternalError", pysqlite_InternalError,
+    ADD_EXCEPTION(module, "InternalError", state->InternalError,
                   state->DatabaseError);
     ADD_EXCEPTION(module, "OperationalError", pysqlite_OperationalError,
                   state->DatabaseError);

Modules/_sqlite/module.h

@@ -33,6 +33,7 @@ typedef struct {
     PyObject *DatabaseError;
     PyObject *Error;
     PyObject *InterfaceError;
+    PyObject *InternalError;
     PyObject *Warning;
     PyObject *lru_cache;
     PyTypeObject *ConnectionType;
@@ -50,7 +51,6 @@ pysqlite_get_state(PyObject *Py_UNUSED(module))
     return &pysqlite_global_state;
 }
 
-extern PyObject* pysqlite_InternalError;
 extern PyObject* pysqlite_OperationalError;
 extern PyObject* pysqlite_ProgrammingError;
 extern PyObject* pysqlite_IntegrityError;

Modules/_sqlite/util.c

@@ -53,7 +53,7 @@ _pysqlite_seterror(sqlite3 *db)
             break;
         case SQLITE_INTERNAL:
         case SQLITE_NOTFOUND:
-            PyErr_SetString(pysqlite_InternalError, sqlite3_errmsg(db));
+            PyErr_SetString(state->InternalError, sqlite3_errmsg(db));
             break;
         case SQLITE_NOMEM:
             (void)PyErr_NoMemory();