Skip to content

Fix: KeyError 'filename'. #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2021
Merged

Fix: KeyError 'filename'. #386

merged 1 commit into from
May 29, 2021

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Dec 3, 2020 •
edited
Loading

By dropping the f() function (and dropping Python 3.5
compatibility), as the real f-string do not have the issue with
non-locals.

closes #299, #300, #283

@JulienPalard JulienPalard mentioned this pull request Dec 3, 2020
Closed
@Mariatta
Copy link
Member

@larryhastings Would you be able to review this, and possibly publish to PyPI?

@JulienPalard
Fix: KeyError 'filename'.
821c11d 
By dropping the `f()` function (and dropping Python 3.5
compatibility), as the real `f-string` do not have the issue with
non-locals.

closes #299, #300
@JulienPalard
Copy link
Member Author

Ran $ ../../core-workflow/blurb/blurb.py merge -f build/NEWS on master and this branch, spotted no diff in the generated file.

@dmerejkowsky
Copy link
Contributor

Looks good to me :)

@JulienPalard JulienPalard merged commit b8dba09 into python:master May 29, 2021
@JulienPalard JulienPalard deleted the mdk/nonlocals branch May 29, 2021 14:46
@merwok merwok mentioned this pull request Jul 12, 2021
Merged
@hugovk hugovk mentioned this pull request Jan 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryhastings larryhastings Awaiting requested review from larryhastings

@Mariatta Mariatta Awaiting requested review from Mariatta

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[blurb] f-string simulation does not work with closures.
4 participants
@JulienPalard @Mariatta @dmerejkowsky @the-knights-who-say-ni