Skip to content

Commit b73b337

Browse files
committed
use easier to understand name
1 parent fdbcb68 commit b73b337

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

CHANGELOG.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
Changelog
33
=========
44

5-
3.17.0
5+
3.17.0
66
-------------------
77

8-
* Change default seed to be different per test. Add the option ``--randomly-dont-seed-per-test`` to enable the old behavior.
8+
* Change default seed to be different per test. Add the option ``--randomly-use-same-seed-per-test`` to enable the old behavior.
99

1010
Resolves `Issue #600 <https://github.com/pytest-dev/pytest-randomly/issues/600>`__
1111

src/pytest_randomly/__init__.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -106,13 +106,11 @@ def pytest_addoption(parser: Parser) -> None:
106106
help="Stop pytest-randomly from randomly reorganizing the test order.",
107107
)
108108
group._addoption(
109-
"--randomly-dont-seed-per-test",
109+
"--randomly-use-same-seed-per-test",
110110
action="store_false",
111-
dest="randomly_seed_per_test",
112-
default=True,
113-
help="""Use a different seed for each test. Can be helpful for getting
114-
different random data in each test, but still having reproducible
115-
tests. Default behaviour: False.""",
111+
dest="same_seed_per_test",
112+
default=False,
113+
help="""Use a the same random seed for each test. Reproduces legacy behavior of pytest-randomly.""",
116114
)
117115

118116

@@ -218,10 +216,10 @@ def seed_from_string(string: str) -> int:
218216

219217
def pytest_runtest_call(item: Item) -> None:
220218
if item.config.getoption("randomly_reset_seed"):
221-
if item.config.getoption("randomly_seed_per_test"):
222-
test_offset = seed_from_string(item.nodeid) + 100
223-
else:
219+
if item.config.getoption("same_seed_per_test"):
224220
test_offset = 0
221+
else:
222+
test_offset = seed_from_string(item.nodeid) + 100
225223
_reseed(item.config, offset=test_offset)
226224

227225

tests/test_pytest_randomly.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def test_b():
7979
"""
8080
)
8181
out = ourtester.runpytest(
82-
"--randomly-dont-reorganize", "--randomly-dont-seed-per-test"
82+
"--randomly-dont-reorganize", "--randomly-use-same-seed-per-test"
8383
)
8484
out.assert_outcomes(passed=2, failed=0)
8585

@@ -627,7 +627,7 @@ def test_two(myfixture):
627627
assert random.getstate() == state_at_seed_two
628628
"""
629629
)
630-
args = ["--randomly-seed=2", "--randomly-dont-seed-per-test"]
630+
args = ["--randomly-seed=2", "--randomly-use-same-seed-per-test"]
631631

632632
out = ourtester.runpytest(*args)
633633
out.assert_outcomes(passed=2)
@@ -659,7 +659,7 @@ def test_b():
659659
"""
660660
)
661661

662-
out = ourtester.runpytest("--randomly-seed=1", "--randomly-dont-seed-per-test")
662+
out = ourtester.runpytest("--randomly-seed=1", "--randomly-use-same-seed-per-test")
663663
out.assert_outcomes(passed=2)
664664

665665

@@ -718,7 +718,7 @@ def test_b():
718718
"""
719719
)
720720

721-
out = ourtester.runpytest("--randomly-seed=1", "--randomly-dont-seed-per-test")
721+
out = ourtester.runpytest("--randomly-seed=1", "--randomly-use-same-seed-per-test")
722722
out.assert_outcomes(passed=2)
723723

724724

@@ -791,7 +791,9 @@ def fake_entry_points(*, group):
791791
entry_points.append(_FakeEntryPoint("test_seeder", reseed))
792792

793793
# Need to run in-process so that monkeypatching works
794-
pytester.runpytest_inprocess("--randomly-seed=1", "--randomly-dont-seed-per-test")
794+
pytester.runpytest_inprocess(
795+
"--randomly-seed=1", "--randomly-use-same-seed-per-test"
796+
)
795797
assert reseed.mock_calls == [
796798
mock.call(1),
797799
mock.call(1),
@@ -802,7 +804,7 @@ def fake_entry_points(*, group):
802804

803805
reseed.mock_calls[:] = []
804806
pytester.runpytest_inprocess(
805-
"--randomly-seed=424242", "--randomly-dont-seed-per-test"
807+
"--randomly-seed=424242", "--randomly-use-same-seed-per-test"
806808
)
807809
assert reseed.mock_calls == [
808810
mock.call(424242),

0 commit comments

Comments
 (0)