Subject: Feature Proposal: Group-colored points for pst.plot(kind='1to1')

[emmieboettch]

I'd like to propose a new feature for the pst.plot(kind='1to1') function: the ability to color the individual points on the 1-to-1 plot based on a grouping variable.

I'm interested in contributing this feature, and I'm wondering about the preferred approach for implementation. My initial thought is to add an argument to res_1to1 that allows for this grouping.

Specifically, would the preference be to add a boolean argument? (e.g., color_by_group=True, where the grouping is implicitly derived from a pre-defined attribute or another argument) and/or add an argument to specify the grouping column? (e.g., group_column='my_group_name_column') This would be more flexible, allowing users to define their own grouping.

I'm happy to put in the work to code this up, but I'd appreciate some guidance on the best way to integrate it into the existing codebase and what kind of argument structure would be most consistent with PyEMU's design philosophy.

Thanks!

[briochh]

Hi @emmieboettch , definitely open to suggestions and PRs for improvements. There is a lot of room for improvements in those plotting methods. It is tricky to cover off all the common use-cases. I wouldn't stress too much about design philosophy. It is mostly, "if it works it works".

[emmieboettch]

Awesome. thanks for the quick response -- I'll be pursuing this change.