Remove importing IN_BROWSER from pyodide.ffi (#255)

Author: ryanking13

micropip/_compat/__init__.py

@@ -4,9 +4,9 @@
 
 compatibility_layer: type[CompatibilityLayer]
 
-IN_BROWSER = "_pyodide_core" in sys.modules
+_IN_PYODIDE = "_pyodide_core" in sys.modules
 
-if IN_BROWSER:
+if _IN_PYODIDE:
     from ._compat_in_pyodide import CompatibilityInPyodide
 
     compatibility_layer = CompatibilityInPyodide

micropip/_compat/_compat_in_pyodide.py

@@ -1,7 +1,7 @@
 from pathlib import Path
 from urllib.parse import urlparse
 
-from pyodide.ffi import IN_BROWSER, to_js
+from pyodide.ffi import to_js
 from pyodide.http import pyfetch
 
 from .compatibility_layer import CompatibilityLayer
@@ -16,10 +16,10 @@
 
     LOCKFILE_PACKAGES = pyodide_js._api.lockfile_packages.to_py()
     LOCKFILE_INFO = pyodide_js._api.lockfile_info.to_py()
-except ImportError:
-    if IN_BROWSER:
-        raise
-    # Otherwise, this is pytest test collection so let it go.
+except ImportError as e:
+    raise ImportError(
+        "Failed to import pyodide modules, please report this issue to Pyodide team."
+    ) from e
 
 
 class CompatibilityInPyodide(CompatibilityLayer):

pyproject.toml

@@ -74,3 +74,6 @@ ignore_missing_imports = true
 [[tool.mypy.overrides]]
 module = "micropip._vendored.*"
 warn_unreachable = false
+
+[tool.pytest.ini_options]
+addopts = "--ignore=micropip/_vendored --ignore=micropip/_compat --doctest-modules"