Unnecessary generator - rewrite as a list comprehension

Author: DimitriPapadopoulos

xarray/core/groupby.py

@@ -540,7 +540,7 @@ def factorize(self) -> EncodedGroups:
         _flatcodes = where(mask.data, -1, _flatcodes)
 
         full_index = pd.MultiIndex.from_product(
-            list(grouper.full_index.values for grouper in groupers),
+            [grouper.full_index.values for grouper in groupers],
             names=tuple(grouper.name for grouper in groupers),
         )
         if not full_index.is_unique:

xarray/core/treenode.py

@@ -786,12 +786,12 @@ def _path_to_ancestor(self, ancestor: NamedNode) -> NodePath:
             raise NotFoundInTreeError(
                 "Cannot find relative path to ancestor because nodes do not lie within the same tree"
             )
-        if ancestor.path not in list(a.path for a in (self, *self.parents)):
+        if ancestor.path not in [a.path for a in (self, *self.parents)]:
             raise NotFoundInTreeError(
                 "Cannot find relative path to ancestor because given node is not an ancestor of this node"
             )
 
-        parents_paths = list(parent.path for parent in (self, *self.parents))
+        parents_paths = [parent.path for parent in (self, *self.parents)]
         generation_gap = list(parents_paths).index(ancestor.path)
         path_upwards = "../" * generation_gap if generation_gap > 0 else "."
         return NodePath(path_upwards)

xarray/structure/concat.py

@@ -418,7 +418,7 @@ def process_subset_opt(opt, subset):
             elif opt == "all":
                 concat_over.update(
                     set().union(
-                        *list(set(getattr(d, subset)) - set(d.dims) for d in datasets)
+                        *[set(getattr(d, subset)) - set(d.dims) for d in datasets]
                     )
                 )
             elif opt == "minimal":

xarray/tests/test_datatree.py

@@ -837,7 +837,7 @@ def test_nones(self) -> None:
 
     def test_full(self, simple_datatree) -> None:
         dt = simple_datatree
-        paths = list(node.path for node in dt.subtree)
+        paths = [node.path for node in dt.subtree]
         assert paths == [
             "/",
             "/set1",

xarray/tests/test_units.py

@@ -2650,7 +2650,7 @@ def test_searchsorted(self, func, unit, error, dtype):
         data_array = xr.DataArray(data=array)
 
         scalar_types = (int, float)
-        args = list(value * unit for value in func.args)
+        args = [value * unit for value in func.args]
         kwargs = {
             key: (value * unit if isinstance(value, scalar_types) else value)
             for key, value in func.kwargs.items()
@@ -2708,7 +2708,7 @@ def test_numpy_methods_with_args(self, func, unit, error, dtype):
         data_array = xr.DataArray(data=array)
 
         scalar_types = (int, float)
-        args = list(value * unit for value in func.args)
+        args = [value * unit for value in func.args]
         kwargs = {
             key: (value * unit if isinstance(value, scalar_types) else value)
             for key, value in func.kwargs.items()