Merge branch 'master' into enhancement/more-explicit-type-check-in-as_compatible_data

Author: dcherian

.codecov.yml

@@ -0,0 +1,16 @@
+codecov:
+  ci:
+    # by default, codecov doesn't recognize azure as a CI provider
+    - dev.azure.com
+  require_ci_to_pass: yes
+
+coverage:
+  status:
+    project:
+      default:
+        # Require 1% coverage, i.e., always succeed
+        target: 1
+    patch: false
+    changes: false
+
+comment: off

.coveragerc

@@ -1,2 +1,8 @@
 [run]
-omit = xarray/test/*
+omit =
+    xarray/tests/*
+    xarray/core/dask_array_compat.py
+    xarray/core/npcompat.py
+    xarray/core/pdcompat.py
+    xarray/core/pycompat.py
+    xarray/_version.py

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,29 @@
+---
+name: Bug report / Feature request
+about: 'Post a problem or idea'
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+#### MCVE Code Sample
+<!-- In order for the maintainers to efficiently understand and prioritize issues, we ask you post a "Minimal, Complete and Verifiable Example" (MCVE): http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports -->
+
+```python
+# Your code here
+
+```
+
+#### Expected Output
+
+
+#### Problem Description
+<!-- this should explain why the current behavior is a problem and why the expected output is a better solution -->
+
+
+#### Output of ``xr.show_versions()``
+<details>
+# Paste the output here xr.show_versions() here
+
+</details>

.github/ISSUE_TEMPLATE/bug_report.md

@@ -2,4 +2,5 @@
 
  - [ ] Closes #xxxx
  - [ ] Tests added
+ - [ ] Passes `black . && mypy . && flake8`
  - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

.github/PULL_REQUEST_TEMPLATE.md

@@ -32,9 +32,11 @@ pip-log.txt
 
 # Unit test / coverage reports
 .coverage
+.coverage.*
 .tox
 nosetests.xml
 .cache
+.dmypy.json
 .mypy_cache
 .ropeproject/
 .tags*
@@ -64,6 +66,7 @@ dask-worker-space/
 doc/_build
 doc/generated
 xarray/version.py
+xarray/tests/data/*.grib.*.idx
 
 # Sync tools
 Icon*

.gitignore

@@ -1,16 +1,6 @@
-# File : .pep8speaks.yml
-
-# This should be kept in sync with the duplicate config in the [pycodestyle]
-# block of setup.cfg.
+# https://github.com/OrkoHunter/pep8speaks for more info
+# pep8speaks will use the flake8 configs in `setup.cfg`
 
 scanner:
-    diff_only: False  # If True, errors caused by only the patch are shown
-
-pycodestyle:
-    max-line-length: 79
-    ignore:  # Errors and warnings to ignore
-        - E402  # module level import not at top of file
-        - E731  # do not assign a lambda expression, use a def
-        - E741  # ambiguous variable name
-        - W503  # line break before binary operator
-        - W504  # line break after binary operator
+    diff_only: False
+    linter: flake8

.pep8speaks.yml

@@ -0,0 +1,29 @@
+# https://pre-commit.com/
+# https://github.com/python/black#version-control-integration
+repos:
+  - repo: https://github.com/python/black
+    rev: stable
+    hooks:
+      - id: black
+        language_version: python3.7
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v2.2.3
+    hooks:
+      - id: flake8
+  - repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v0.720  # Must match ci/requirements/*.yml
+    hooks:
+      - id: mypy
+  # run these occasionally, ref discussion https://github.com/pydata/xarray/pull/3194
+  # - repo: https://github.com/asottile/pyupgrade
+  #   rev: v1.22.1
+  #   hooks:
+  #     - id: pyupgrade
+  #       args:
+  #         - "--py3-only"
+  #         # remove on f-strings in Py3.7
+  #         - "--keep-percent-format"
+  # - repo: https://github.com/timothycrosley/isort
+  #   rev: 4.3.21-2
+  #   hooks:
+  #     - id: isort

.pre-commit-config.yaml

@@ -5,8 +5,15 @@ Time required: about an hour.
  1. Ensure your master branch is synced to upstream:
        git pull upstream master
  2. Look over whats-new.rst and the docs. Make sure "What's New" is complete
-    (check the date!) and add a brief summary note describing the release at the
-    top.
+    (check the date!) and consider adding a brief summary note describing the
+    release at the top.
+    Things to watch out for:
+    - Important new features should be highlighted towards the top.
+    - Function/method references should include links to the API docs.
+    - Sometimes notes get added in the wrong section of whats-new, typically
+      due to a bad merge. Check for these before a release by using git diff,
+      e.g., ``git diff v0.X.Y whats-new.rst`` where 0.X.Y is the previous
+      release.
  3. If you have any doubts, run the full test suite one final time!
       py.test
  4. On the master branch, commit the release in git: