Skip to content

Commit ad126f5

Browse files
committed
Remove explicit get_internals() from TEST_CASE("Threads") and REQUIRE(has_pybind11_internals_static()); along with it, based on #4218 (comment)
1 parent f12f194 commit ad126f5

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

tests/test_embed/test_interpreter.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -292,11 +292,6 @@ TEST_CASE("Threads") {
292292
auto locals = py::dict("count"_a = 0);
293293

294294
{
295-
// This used to be triggered by py::gil_scoped_release().
296-
// TODO: Explain why/how this is relevant to this unit test.
297-
py::detail::get_internals();
298-
REQUIRE(has_pybind11_internals_static());
299-
300295
py::gil_scoped_release gil_release{};
301296

302297
auto threads = std::vector<std::thread>();

0 commit comments

Comments
 (0)