chore: steal arg_v.value from copied arg in unpacking_collector (#4219)

Skylion007 · web-flow · commit 864ed1120c70 · 2022-10-06T16:11:34.000-04:00
diff --git a/include/pybind11/cast.h b/include/pybind11/cast.h
@@ -1545,7 +1545,7 @@ class unpacking_collector {
             throw cast_error_unable_to_convert_call_arg(a.name, a.type);
 #endif
         }
-        m_kwargs[a.name] = a.value;
+        m_kwargs[a.name] = std::move(a.value);
     }
 
     void process(list & /*args_list*/, detail::kwargs_proxy kp) {

Original file line number	Diff line number	Diff line change
`@@ -1545,7 +1545,7 @@ class unpacking_collector {`
`1545`	`1545`	`throw cast_error_unable_to_convert_call_arg(a.name, a.type);`
`1546`	`1546`	`#endif`
`1547`	`1547`	`}`
`1548`		`- m_kwargs[a.name] = a.value;`
	`1548`	`+ m_kwargs[a.name] = std::move(a.value);`
`1549`	`1549`	`}`
`1550`	`1550`
`1551`	`1551`	`void process(list & /args_list/, detail::kwargs_proxy kp) {`