Skip to content

Commit 9537c4b

Browse files
committed
unit tests for deprecate_bookmark decorator
1 parent 2a6b7c5 commit 9537c4b

File tree

2 files changed

+38
-0
lines changed

2 files changed

+38
-0
lines changed

tests/test_merger.py

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,3 +296,26 @@ def test_iss1145():
296296
name = "iss1145.pdf"
297297
merger = PdfMerger()
298298
merger.append(PdfReader(BytesIO(get_pdf_from_url(url, name=name))))
299+
300+
301+
def test_deprecate_bookmark_decorator_warning():
302+
reader = PdfReader(
303+
os.path.join(RESOURCE_ROOT, "outlines-with-invalid-destinations.pdf")
304+
)
305+
merger = PdfMerger()
306+
with pytest.warns(
307+
UserWarning,
308+
match="import_bookmarks is deprecated as an argument. Use import_outline instead",
309+
):
310+
merger.merge(0, reader, import_bookmarks=True)
311+
312+
313+
@pytest.mark.filterwarnings("ignore::UserWarning")
314+
def test_deprecate_bookmark_decorator_output():
315+
reader = PdfReader(
316+
os.path.join(RESOURCE_ROOT, "outlines-with-invalid-destinations.pdf")
317+
)
318+
merger = PdfMerger()
319+
merger.merge(0, reader, import_bookmarks=True)
320+
first_oi_title = 'Valid Destination: Action /GoTo Named Destination "section.1"'
321+
assert merger.outline[0].title == first_oi_title

tests/test_writer.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -602,3 +602,18 @@ def test_add_single_annotation():
602602

603603
# Cleanup
604604
os.remove(target) # remove for testing
605+
606+
607+
def test_deprecate_bookmark_decorator():
608+
reader = PdfReader(
609+
os.path.join(RESOURCE_ROOT, "outlines-with-invalid-destinations.pdf")
610+
)
611+
page = reader.pages[0]
612+
outline_item = reader.outline[0]
613+
writer = PdfWriter()
614+
writer.add_page(page)
615+
with pytest.warns(
616+
UserWarning,
617+
match="bookmark is deprecated as an argument. Use outline_item instead",
618+
):
619+
writer.add_outline_item_dict(bookmark=outline_item)

0 commit comments

Comments
 (0)