Purescript 0.9.1 update #30
Conversation
|
I was about to do this myself. |
| }, | ||
| "devDependencies": { | ||
| "purescript-console": "~0.1.1" | ||
| "purescript-console": "~1.0.0" |
There was a problem hiding this comment.
Can you use ^ rather than ~ for all dependencies please?
There was a problem hiding this comment.
Of course. I left the range specs as they were there previously.
There was a problem hiding this comment.
Yeah, it's a mixture of: bower used to default to ~, and it didn't matter as we were on 0.x.y anyway. As of the v1 releases using ^ means we can make additive changes to libraries without having to re-release things further down the chain.
|
@paf31 / @hdgarrood do you think we should be using |
| @@ -31,24 +31,28 @@ module Node.FS.Async | |||
| , fdClose | |||
| ) where | |||
|
|
|||
| import Prelude | |||
| import Control.Monad.Eff | |||
| import Prelude (Unit, bind, show, flip, ($), (<<<), (/), (<$>)) | |||
There was a problem hiding this comment.
Can you use an open import for Prelude please?
|
Since it's easy to convert between the two, and given that quite a few people use this library directly, I'm tempted to say |
|
Ok, cool. That was my thinking on the pro-using- |
1. Caret ranges in bower.json instead of tilde #30 (comment) 2. Open import for Prelude #30 (comment)
|
Import for Prelude opened (is this the current convention?), tilde ranges replaced with caret ones. Not sure if there's work required on the JSData/DateTime: the low level stuff is in JSDate and all computations are in DateTime and friends. Seems very nice and logical to me. |
|
It is - the compiler lets you have one open import without warnings now, and so having Prelude as an open import means that you don't have to be updating the import list as often, and also reduces the risk of merge conflicts. |
| import Prelude | ||
| import Data.Maybe | ||
| import Data.Either | ||
| import Prelude (Unit, bind, (==)) |
There was a problem hiding this comment.
If we make this open, can we get rid of the imports of Control.Apply and Control.Bind too?
1. Getting rid of `import Control.Apply` and `.Bind` #30 (comment) 2. Prelude made open in test/ (forgotten change)
|
Done. Didn't know that compiler allows one open import. Very convenient. @hdgarrood while I have your attention: in whose court is the |
|
|
|
@garyb I thought this PR make the build fail (though I believe it's just bad timing, infamous |
|
Looks great. Thanks very much! |
|
Re |
|
I can look at this later today unless someone beats me to it. |
|
Will these changes make it into a release any time soon? |
Please consider this PR for update to 0.9.1 compiler.
Fixes #29