feat: use https://github.com/srghma/purescript-foreign-js-set

Author: Serhii Khoma

packages.dhall

@@ -126,6 +126,15 @@ let overrides =
       upstream.web-dom // { repo = "https://github.com/srghma/purescript-web-dom.git", version = "patch-1" }
   }
 
-let additions = {=}
+let additions =
+  { foreign-js-set =
+      { dependencies =
+          [ "console", "effect", "psci-support" ]
+      , repo =
+          "https://github.com/srghma/purescript-foreign-js-set.git"
+      , version =
+          "master"
+      }
+  }
 
 in  upstream // overrides // additions

spago.dhall

@@ -22,6 +22,7 @@ You can edit this file as you like.
   , "strings"
   , "control"
   , "lazy"
+  , "foreign-js-set"
   ]
 , packages = ./packages.dhall
 , sources = [ "src/**/*.purs", "test/**/*.purs" ]

src/Halogen/VDom/DOM/Prop/Checkers.purs

@@ -12,7 +12,8 @@ import Effect.Uncurried as EFn
 import Halogen.VDom.Attributes (attributes, forEachE) as Attributes
 import Halogen.VDom.DOM.Prop.Types (Prop, PropValue)
 import Halogen.VDom.DOM.Prop.Util (unsafeGetProperty)
-import Halogen.VDom.Set as Set
+import Foreign.JsSet (JsSet)
+import Foreign.JsSet as JsSet
 import Halogen.VDom.Types (Namespace)
 import Halogen.VDom.Util as Util
 import Web.DOM.Element (Element) as DOM
@@ -39,16 +40,18 @@ checkPropExistsAndIsEqual propName expectedPropValue element = do
     throwException $ error $ "Expected element to have a prop " <> Util.quote propName <> " eq to " <> Util.quote (Util.anyToString expectedPropValue) <> ", but it was equal to " <> Util.quote (Util.anyToString propValue) <> " (check warning above for more information)"
 
 -- | Inspired by https://github.com/facebook/react/blob/823dc581fea8814a904579e85a62da6d18258830/packages/react-dom/src/client/ReactDOMComponent.js#L1030
-mkExtraAttributeNames ∷ DOM.Element → Effect (Set.Set String)
+mkExtraAttributeNames ∷ DOM.Element → Effect (JsSet String)
 mkExtraAttributeNames el = do
   let
     namedNodeMap = Attributes.attributes el
-  (set ∷ Set.Set String) ← Set.empty
-  EFn.runEffectFn2 Attributes.forEachE namedNodeMap (EFn.mkEffectFn1 \attribute → EFn.runEffectFn2 Set.add attribute.name set)
+  (set ∷ JsSet String) ← JsSet.empty
+  EFn.runEffectFn2 Attributes.forEachE namedNodeMap (EFn.mkEffectFn1 \attribute → EFn.runEffectFn2 JsSet._add attribute.name set)
   pure set
 
-checkExtraAttributeNamesIsEmpty ∷ forall a . Array (Prop a) -> Set.Set String -> DOM.Element -> Effect Unit
-checkExtraAttributeNamesIsEmpty propsToHydrate extraAttributeNames element =
-  when (Set.size extraAttributeNames > 0) do
+checkExtraAttributeNamesIsEmpty ∷ forall a . Array (Prop a) -> JsSet String -> DOM.Element -> Effect Unit
+checkExtraAttributeNamesIsEmpty propsToHydrate extraAttributeNames element = do
+  size <- EFn.runEffectFn1 JsSet._size extraAttributeNames
+  when (size > 0) do
     EFn.runEffectFn2 Util.warnAny "Error info: " { extraAttributeNames, element, propsToHydrate }
-    throwException $ error $ "Extra attributes from the server: " <> (Set.toArray extraAttributeNames # joinWith ", ") <> " (check warning above for more information)"
+    extraAttributeNames' <- EFn.runEffectFn1 JsSet._toArray extraAttributeNames
+    throwException $ error $ "Extra attributes from the server: " <> joinWith ", " extraAttributeNames' <> " (check warning above for more information)"

src/Halogen/VDom/DOM/Prop/Implementation.purs

@@ -15,7 +15,8 @@ import Foreign.Object as Object
 import Halogen.VDom.DOM.Prop.Checkers (checkAttributeExistsAndIsEqual, checkPropExistsAndIsEqual)
 import Halogen.VDom.DOM.Prop.Types (ElemRef(..), EmitterInputBuilder, EventListenerAndCurrentEmitterInputBuilder, Prop(..), PropValue)
 import Halogen.VDom.DOM.Prop.Util (removeProperty, setProperty, unsafeGetProperty)
-import Halogen.VDom.Set as Set
+import Foreign.JsSet (JsSet)
+import Foreign.JsSet as JsSet
 import Halogen.VDom.Util (STObject', anyToString, fullAttributeName, quote)
 import Halogen.VDom.Util as Util
 import Web.DOM.Element (Element) as DOM
@@ -24,24 +25,24 @@ import Web.Event.EventTarget (eventListener, EventListener) as DOM
 import Foreign (unsafeToForeign, typeOf)
 import Unsafe.Coerce (unsafeCoerce)
 
-deleteRequiredElement :: EFn.EffectFn2 String (Set.Set String) Unit
+deleteRequiredElement :: EFn.EffectFn2 String (JsSet String) Unit
 deleteRequiredElement = EFn.mkEffectFn2 \element extraAttributeNames -> do
-  let isPresent = Fn.runFn2 Set.has element extraAttributeNames
+  isPresent <- EFn.runEffectFn2 JsSet._has element extraAttributeNames
   if isPresent
-    then EFn.runEffectFn2 Set.delete element extraAttributeNames
+    then EFn.runEffectFn2 JsSet._delete element extraAttributeNames
     else do
       EFn.runEffectFn2 Util.warnAny "Error info: " { element, extraAttributeNames }
       throwException $ error $ "Cannot delete element " <> quote element <> " that is not present in extraAttributeNames (check warning above for more information)"
 
-checkPropExistsAndIsEqualAndDelete :: EFn.EffectFn5 (Set.Set String) String PropValue DOM.Element String Unit
+checkPropExistsAndIsEqualAndDelete :: EFn.EffectFn5 (JsSet String) String PropValue DOM.Element String Unit
 checkPropExistsAndIsEqualAndDelete = EFn.mkEffectFn5 \extraAttributeNames propName val el correspondingAttributeName -> do
   checkPropExistsAndIsEqual propName val el
   EFn.runEffectFn2 deleteRequiredElement correspondingAttributeName extraAttributeNames
 
 hydrateApplyProp
   ∷ ∀ a
   . Fn.Fn4
-  (Set.Set String)
+  (JsSet String)
   DOM.Element
   (a → Effect Unit)
   (STObject' (EventListenerAndCurrentEmitterInputBuilder a))