Skip to content

Made the README example runable #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2021
Merged

Made the README example runable #37

merged 2 commits into from
Nov 21, 2021

Conversation

dk949
Copy link
Contributor

@dk949 dk949 commented Nov 20, 2021 •
edited
Loading

Description of the change
Updating the README example so it can be compiled

  • added module Main where
  • removed import of jsonParser from Data.Argonaut.Core
  • renamed json to sampleJson
  • added a missing colon to the FFI export

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • N/A: Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • N/A: Added a test for the contribution (if applicable)

dk949 added 2 commits November 20, 2021 21:53
@dk949
Made the README example runable
ec8ae01 
added `module Main where`
removed import of `jsonParser` from `Data.Argonaut.Core`
renamed `json` to `sampleJson`
@dk949
updated CHANGELOG
52f1027
@thomashoneyman thomashoneyman merged commit 6863be9 into purescript-contrib:main Nov 21, 2021
@dk949 dk949 deleted the patch-1 branch November 21, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dk949 @thomashoneyman