Skip to content

Commit f607960

Browse files
SNCB: skip all E2E tests after endpoint permanently shut down
See #284
1 parent 1aa483c commit f607960

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

p/readme.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ There are built-in profiles for these public transportation networks:
88

99
HAFAS endpoint | wrapper library | docs | example code | profile name
1010
-|-|-|-|-
11-
[Deutsche Bahn (DB)](https://en.wikipedia.org/wiki/Deutsche_Bahn) | [`db-hafas`](https://github.com/public-transport/db-hafas) | [docs](db/readme.md) | [example](db/example.js) | [`db`](db)
11+
[Deutsche Bahn (DB)](https://en.wikipedia.org/wiki/Deutsche_Bahn) | [`db-hafas`](https://github.com/public-transport/db-hafas) | [docs](db/readme.md) | [example](db/example.js) | [`db`](db) (endpoint shut down, see [#331](https://github.com/public-transport/hafas-client/issues/331))
1212
[Polskie Koleje Państwowe (PKP)](https://en.wikipedia.org/wiki/Polish_State_Railways) | [`pkp-hafas`](https://github.com/juliuste/pkp-hafas) | [docs](pkp/readme.md) | [example](pkp/example.js) | [`pkp`](pkp)
13-
[Belgian National Railways (SNCB/NMBS)](https://en.wikipedia.org/wiki/National_Railway_Company_of_Belgium) | - | [docs](sncb/readme.md) | [example](sncb/example.js) | [`sncb`](sncb) (currently broken)
13+
[Belgian National Railways (SNCB/NMBS)](https://en.wikipedia.org/wiki/National_Railway_Company_of_Belgium) | - | [docs](sncb/readme.md) | [example](sncb/example.js) | [`sncb`](sncb) (endpoint shut down, see [#284](https://github.com/public-transport/hafas-client/issues/284))
1414
[*Iarnród Éireann* (Irish Rail)](https://en.wikipedia.org/wiki/Iarnród_Éireann) | - | [docs](irish-rail/readme.md) | [example](irish-rail/example.js) | [`irish-rail`](irish-rail)
1515
[Berlin & Brandenburg public transport (VBB)](https://en.wikipedia.org/wiki/Verkehrsverbund_Berlin-Brandenburg) | [`vbb-hafas`](https://github.com/public-transport/vbb-hafas) | [docs](vbb/readme.md) | [example](vbb/example.js) | [`vbb`](vbb)
1616
[Berlin public transport (BVG)](https://en.wikipedia.org/wiki/Berliner_Verkehrsbetriebe) | [`bvg-hafas`](https://github.com/public-transport/bvg-hafas) | [docs](bvg/readme.md) | [example](bvg/example.js) | [`bvg`](bvg)

p/sncb/readme.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
# SNCB profile for `hafas-client`
22

3-
*Note:* **This profile is currently broken** because [SNCB has switched the HAFAS API style](https://github.com/public-transport/hafas-client/issues/284) and we haven't migrated to the new API.
3+
> [!IMPORTANT]
4+
> The underlying [SNCB HAFAS API has been permanently shut down](https://github.com/public-transport/hafas-client/issues/284).
5+
> The API responds with: "This feature is no longer available. To plan your trip, download the new SNCB app."
6+
7+
> [!TIP]
8+
> **Alternative:** For Belgian railway data, consider using the [iRail API](https://api.irail.be/) instead.
9+
> - Documentation: https://docs.irail.be/
10+
> - GitHub: https://github.com/iRail
411
512
[*Société nationale des chemins de fer belges (SNCB)*/*Nationale Maatschappij der Belgische Spoorwegen (NMBS)*](https://en.wikipedia.org/wiki/National_Railway_Company_of_Belgium) is the major public transport provider of [Belgium](https://en.wikipedia.org/wiki/Belgium). This profile adds *SNCB*-specific customizations to `hafas-client`.
613

test/e2e/sncb.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
// Note: All tests in this file are skipped because the SNCB/NMBS HAFAS endpoint
2+
// has been permanently shut down.
3+
// API response: "This feature is no longer available. To plan your trip, download the new SNCB app."
4+
// See https://github.com/public-transport/hafas-client/issues/284
5+
16
import tap from 'tap';
27

38
import {createWhen} from './lib/util.js';
@@ -33,7 +38,7 @@ const gentPaddenhoek = {
3338
latitude: 51.051691, longitude: 3.724914,
3439
};
3540

36-
tap.test('journeys – Gent Sant Pieters to Bruxelles Midi', async (t) => {
41+
tap.skip('journeys – Gent Sant Pieters to Bruxelles Midi', async (t) => {
3742
const res = await client.journeys(gentStPieters, bruxellesMidi, {
3843
results: 4,
3944
departure: when,
@@ -53,7 +58,7 @@ tap.test('journeys – Gent Sant Pieters to Bruxelles Midi', async (t) => {
5358
// todo: via works – with detour
5459
// todo: without detour
5560

56-
tap.test('trip details', async (t) => {
61+
tap.skip('trip details', async (t) => {
5762
const res = await client.journeys(gentStPieters, bruxellesMidi, {
5863
results: 1, departure: when,
5964
});
@@ -68,7 +73,7 @@ tap.test('trip details', async (t) => {
6873
t.end();
6974
});
7075

71-
tap.test('arrivals at Bruxelles Midi', async (t) => {
76+
tap.skip('arrivals at Bruxelles Midi', async (t) => {
7277
const res = await client.arrivals(bruxellesMidi, {
7378
duration: 10, when,
7479
});
@@ -84,7 +89,7 @@ tap.test('arrivals at Bruxelles Midi', async (t) => {
8489

8590
// todo: nearby
8691

87-
tap.test('radar', async (t) => {
92+
tap.skip('radar', async (t) => {
8893
const res = await client.radar({
8994
north: 51.065,
9095
west: 3.688,
@@ -98,7 +103,7 @@ tap.test('radar', async (t) => {
98103
t.end();
99104
});
100105

101-
tap.test('reachableFrom', async (t) => {
106+
tap.skip('reachableFrom', async (t) => {
102107
await testReachableFrom({
103108
test: t,
104109
reachableFrom: client.reachableFrom,

0 commit comments

Comments
 (0)