chore: update V8 to 13.8.258.26 #442
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonm1
requested review from
PiotrSikora,
martijneken and
mpwarres
as code owners
Signed-off-by: Michael Warres <[email protected]>
Signed-off-by: Michael Warres <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Zig CC had linking errors with -latomic (a seemingly recurrent issue with zig), which is required by the new V8 version. Instead, llvm can be used. Signed-off-by: Matt Leon <[email protected]>
This test fails with the new V8 version Signed-off-by: Matt Leon <[email protected]>
PiotrSikora
reviewed
Jul 17, 2025
* add download links for darwin * rename from zig-cc to hermetic-llvm Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
BSD sed requires an extension to create a backup file when used with in-place editing. Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
martijneken
approved these changes
Jul 18, 2025
Simdutf has this check for enabling atomic operations:
```
#if __cpp_lib_atomic_ref >= 201806L
#define SIMDUTF_ATOMIC_REF 1
#endif // __cpp_lib_atomic_ref
```
Which evidently fails on the runner's macos version, which spits out the following error:
```
external/v8/src/builtins/builtins-typed-array.cc:524:28: error: no member named 'atomic_base64_to_binary_safe' in namespace 'simdutf'; did you mean 'base64_to_binary_safe'?
524 | simd_result = simdutf::atomic_base64_to_binary_safe(
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| base64_to_binary_safe
external/simdutf/simdutf.h:4369:1: note: 'base64_to_binary_safe' declared here
4369 | base64_to_binary_safe(const char *input, size_t length, char *output,
| ^
external/v8/src/builtins/builtins-typed-array.cc:837:35: error: no member named 'atomic_binary_to_base64' in namespace 'simdutf'; did you mean 'binary_to_base64'?
837 | simd_result_size = simdutf::atomic_binary_to_base64(
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
| binary_to_base64
external/simdutf/simdutf.h:4110:8: note: 'binary_to_base64' declared here
4110 | size_t binary_to_base64(const char *input, size_t length, char *output,
| ^
external/v8/src/builtins/builtins-typed-array.cc:525:9: error: cannot initialize a parameter of type 'const char *' with an rvalue of type 'const char16_t *'
```
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
leonm1
force-pushed
the
chore/update-v8
branch
2 times, most recently
from
aabaa9e to
0304328
Compare
leonm1
force-pushed
the
chore/update-v8
branch
2 times, most recently
from
9e92ecb to
7ab78e9
Compare
leonm1
force-pushed
the
chore/update-v8
branch
4 times, most recently
from
f8feda4 to
b213f3d
Compare
Signed-off-by: Matt Leon <[email protected]>
macos-15 uses too new a version of python which lacks support for `pipes`, which is used by our old foreign_cc version.
```
rules_foreign_cc: Printing build logs:
/bin/bash -c bazel-out/darwin_arm64-opt-exec-2B5CBBC6-ST-1710242dce5b/bin/external/rules_foreign_cc/toolchains/ninja_tool_foreign_cc/wrapper_build_script.sh)
_____ BEGIN BUILD LOGS _____
+ ./configure.py --bootstrap
Traceback (most recent call last):
File "/private/var/tmp/_bazel_runner/f7b5b126cb65bf12475e292acf07553d/sandbox/darwin-sandbox/120/execroot/proxy_wasm_cpp_host/bazel-out/darwin_arm64-opt-exec-2B5CBBC6-ST-1710242dce5b/bin/external/rules_foreign_cc/toolchains/ninja.build_tmpdir/./configure.py", line 26, in <module>
import pipes
ModuleNotFoundError: No module named 'pipes'
```
Signed-off-by: Matt Leon <[email protected]>
mpwarres
approved these changes
Jul 18, 2025
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of #441.