chore: fix llvm builds:

* add download links for darwin
* rename from zig-cc to hermetic-llvm

Signed-off-by: Matt Leon <[email protected]>

Author: leonm1

.bazelrc

@@ -67,19 +67,17 @@ build:gcc --action_env=BAZEL_COMPILER=gcc
 build:gcc --action_env=CC=gcc
 build:gcc --action_env=CXX=g++
 
-# Use Zig C/C++ compiler.
-build:zig-cc --incompatible_enable_cc_toolchain_resolution
-build:zig-cc --action_env BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
-build:zig-cc --extra_toolchains @llvm_toolchain//:cc-toolchain-x86_64-linux
-build:zig-cc --extra_toolchains @llvm_aarch64//:cc-toolchain-aarch64-linux
-build:zig-cc --extra_toolchains @emsdk//emscripten_toolchain:cc-toolchain-wasm
-build:zig-cc --host_copt=-fno-sanitize=undefined
-
-# Use Zig C/C++ compiler (cross-compile to Linux/aarch64).
-build:zig-cc-linux-aarch64 --config=zig-cc
-#build:zig-cc-linux-aarch64 --platforms @zig_sdk//platform:linux_arm64
-build:zig-cc-linux-aarch64 --platforms @toolchains_llvm//platforms:linux-aarch64
-build:zig-cc-linux-aarch64 --cxxopt --gcc-install-dir=external/sysroot_linux_arm64/usr/lib/gcc/aarch64-linux-gnu/13/
+# Use vendored LLVM C/C++ compiler.
+build:hermetic-llvm --incompatible_enable_cc_toolchain_resolution
+build:hermetic-llvm --action_env BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
+build:hermetic-llvm --extra_toolchains @llvm_toolchain//:cc-toolchain-x86_64-linux
+build:hermetic-llvm --extra_toolchains @llvm_aarch64//:cc-toolchain-aarch64-linux
+build:hermetic-llvm --extra_toolchains @emsdk//emscripten_toolchain:cc-toolchain-wasm
+
+# Use vendored LLVM C/C++ compiler (cross-compile to Linux/aarch64).
+build:linux-aarch64-cross --config=hermetic-llvm
+build:linux-aarch64-cross --platforms @toolchains_llvm//platforms:linux-aarch64
+build:linux-aarch64-cross --cxxopt --gcc-install-dir=external/sysroot_linux_arm64/usr/lib/gcc/aarch64-linux-gnu/13/
 
 build --enable_platform_specific_config
 
@@ -88,10 +86,6 @@ build:linux --cxxopt=-std=c++20 --host_cxxopt=-std=c++20
 build:macos --cxxopt=-std=c++20 --host_cxxopt=-std=c++20
 build:windows --cxxopt="/std:c++20" --host_cxxopt="/std:c++20"
 
-# For Zig C/C++ compiler.
-build:linux --sandbox_add_mount_pair=/tmp
-build:macos --sandbox_add_mount_pair=/var/tmp
-build:windows --sandbox_add_mount_pair=C:\Temp
 
 # Enable symlinks and runfiles on Windows (enabled by default on other platforms).
 startup --windows_enable_symlinks

.github/workflows/test.yml

@@ -172,7 +172,7 @@ jobs:
           arch: aarch64
           action: test
           targets: -//test/fuzz/...
-          flags: --config=zig-cc-linux-aarch64 --@v8//bazel/config:v8_target_cpu=arm64
+          flags: --config=linux-aarch64-cross --@v8//bazel/config:v8_target_cpu=arm64
           deps: qemu-user-static libc6-arm64-cross
           cache: true
         - name: 'V8 on macOS/x86_64'
@@ -244,7 +244,7 @@ jobs:
           os: ubuntu-24.04
           arch: aarch64
           action: build
-          flags: --config=zig-cc-linux-aarch64
+          flags: --config=linux-aarch64-cross
           deps: qemu-user-static libc6-arm64-cross
         - name: 'Wasmtime on Linux/s390x'
           engine: 'wasmtime'

bazel/dependencies.bzl

@@ -58,28 +58,35 @@ def proxy_wasm_cpp_host_dependencies():
     bazel_toolchain_dependencies()
     llvm_toolchain(
         name = "llvm_toolchain",
-        llvm_version = "18.1.8",
+        llvm_version = "19.1.0",
         sha256 = {
-            "linux-x86_64": "54ec30358afcc9fb8aa74307db3046f5187f9fb89fb37064cdde906e062ebf36",
+            "linux-x86_64": "cee77d641690466a193d9b88c89705de1c02bbad46bde6a3b126793c0a0f2923",
+            "linux-aarch64": "7bb54afd330fe1a1c2d4c593fa1e2dbe2abd9bf34fb3597994ff41e443cf144b",
+            "darwin-aarch64": "9da86f64a99f5ce9b679caf54e938736ca269c5e069d0c94ad08b995c5f25c16",
+            "darwin-x86_64": "264f2f1e8b67f066749349ae8b4943d346cd44e099464164ef21b42a57663540",
         },
         strip_prefix = {
-            "linux-x86_64": "clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04",
+            "linux-x86_64": "LLVM-19.1.0-Linux-X64",
+            "linux-aarch64": "clang+llvm-19.1.0-aarch64-linux-gnu",
+            "darwin-aarch64": "LLVM-19.1.0-macOS-ARM64",
+            "darwin-x86_64": "LLVM-19.1.0-macOS-X64",
         },
         urls = {
-            "linux-x86_64": [
-                "https://github.com/llvm/llvm-project/releases/download/llvmorg-18.1.8/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz",
-            ],
+            "linux-x86_64": ["https://github.com/llvm/llvm-project/releases/download/llvmorg-19.1.0/LLVM-19.1.0-Linux-X64.tar.xz"],
+            "linux-aarch64": ["https://github.com/llvm/llvm-project/releases/download/llvmorg-19.1.0/clang+llvm-19.1.0-aarch64-linux-gnu.tar.xz"],
+            "darwin-aarch64": ["https://github.com/llvm/llvm-project/releases/download/llvmorg-19.1.0/LLVM-19.1.0-macOS-ARM64.tar.xz"],
+            "darwin-x86_64": ["https://github.com/llvm/llvm-project/releases/download/llvmorg-19.1.0/LLVM-19.1.0-macOS-X64.tar.xz"],
         },
     )
 
     llvm_toolchain(
         name = "llvm_aarch64",
-        llvm_version = "18.1.8",
+        llvm_version = "19.1.0",
         toolchain_roots = {
             "": "@llvm_toolchain_llvm//",
         },
         sysroot = {
-          "linux-aarch64": "@sysroot_linux_arm64//:sysroot",
+            "linux-aarch64": "@sysroot_linux_arm64//:sysroot",
         },
     )