Skip to content

Commit fe6edca

Browse files
h-vetinaricopybara-github
authored andcommitted
fix pkg-config metadata for shared abseil on windows (#15888)
Closes #15883, tested in conda-forge/libprotobuf-feedstock#209 Closes #15888 COPYBARA_INTEGRATE_REVIEW=#15888 from h-vetinari:absl_pkgconfig 9062aa9 PiperOrigin-RevId: 609206067
1 parent b785fcb commit fe6edca

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

cmake/install.cmake

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
include(GNUInstallDirs)
22

33
foreach(_target IN LISTS protobuf_ABSL_USED_TARGETS)
4-
string(REPLACE :: _ _modified_target ${_target})
4+
# shared abseil on windows breaks the absl::foo -> absl_foo replacement logic -
5+
# preempt this by a more specific replace (harmless if it doesn't apply); see GH-15883
6+
string(REPLACE "absl::abseil_dll" "abseil_dll" _modified_target ${_target})
7+
string(REPLACE :: _ _modified_target ${_modified_target})
58
list(APPEND _pc_targets ${_modified_target})
69
endforeach()
710
list(APPEND _pc_targets "utf8_range")

0 commit comments

Comments
 (0)