Skip to content

Commit f4d5c2c

Browse files
protobuf-github-botcopybara-github
protobuf-github-bot
authored and
copybara-github
committed
Avoid unused-parameter warning in field accessor listeners.
PiperOrigin-RevId: 603424598
1 parent dc7001e commit f4d5c2c

File tree

1 file changed

+46
-40
lines changed

1 file changed

+46
-40
lines changed

‎src/google/protobuf/field_access_listener.h‎

Lines changed: 46 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,15 @@ struct NoOpAccessListener {
3434
// to differentiate the protos during the runtime before the start of the
3535
// program, use this functor to get its name. We either way need it for
3636
// LITE_RUNTIME protos as they don't have descriptors at all.
37-
explicit NoOpAccessListener(absl::string_view (*name_extractor)()) {}
37+
explicit NoOpAccessListener(absl::string_view (* /*name_extractor*/)()) {}
3838
// called repeatedly during serialization/deserialization/ByteSize of
3939
// Reflection as:
4040
// AccessListener<MessageT>::OnSerialize(this);
41-
static void OnSerialize(const MessageLite* msg) {}
42-
static void OnDeserialize(const MessageLite* msg) {}
43-
static void OnByteSize(const MessageLite* msg) {}
44-
static void OnMergeFrom(const MessageLite* to, const MessageLite* from) {}
41+
static void OnSerialize(const MessageLite* /*msg*/) {}
42+
static void OnDeserialize(const MessageLite* /*msg*/) {}
43+
static void OnByteSize(const MessageLite* /*msg*/) {}
44+
static void OnMergeFrom(const MessageLite* /*to*/,
45+
const MessageLite* /*from*/) {}
4546

4647
// NOTE: This function can be called pre-main. Make sure it does not make
4748
// the state of the listener invalid.
@@ -63,77 +64,82 @@ struct NoOpAccessListener {
6364

6465
// add_<field>(f)
6566
template <int kFieldNum>
66-
static void OnAdd(const MessageLite* msg, const void* field) {}
67+
static void OnAdd(const MessageLite* /*msg*/, const void* /*field*/) {}
6768

6869
// add_<field>()
6970
template <int kFieldNum>
70-
static void OnAddMutable(const MessageLite* msg, const void* field) {}
71+
static void OnAddMutable(const MessageLite* /*msg*/, const void* /*field*/) {}
7172

7273
// <field>() and <repeated_field>(i)
7374
template <int kFieldNum>
74-
static void OnGet(const MessageLite* msg, const void* field) {}
75+
static void OnGet(const MessageLite* /*msg*/, const void* /*field*/) {}
7576

7677
// clear_<field>()
7778
template <int kFieldNum>
78-
static void OnClear(const MessageLite* msg, const void* field) {}
79+
static void OnClear(const MessageLite* /*msg*/, const void* /*field*/) {}
7980

8081
// has_<field>()
8182
template <int kFieldNum>
82-
static void OnHas(const MessageLite* msg, const void* field) {}
83+
static void OnHas(const MessageLite* /*msg*/, const void* /*field*/) {}
8384

8485
// <repeated_field>()
8586
template <int kFieldNum>
86-
static void OnList(const MessageLite* msg, const void* field) {}
87+
static void OnList(const MessageLite* /*msg*/, const void* /*field*/) {}
8788

8889
// mutable_<field>()
8990
template <int kFieldNum>
90-
static void OnMutable(const MessageLite* msg, const void* field) {}
91+
static void OnMutable(const MessageLite* /*msg*/, const void* /*field*/) {}
9192

9293
// mutable_<repeated_field>()
9394
template <int kFieldNum>
94-
static void OnMutableList(const MessageLite* msg, const void* field) {}
95+
static void OnMutableList(const MessageLite* /*msg*/, const void* /*field*/) {
96+
}
9597

9698
// release_<field>()
9799
template <int kFieldNum>
98-
static void OnRelease(const MessageLite* msg, const void* field) {}
100+
static void OnRelease(const MessageLite* /*msg*/, const void* /*field*/) {}
99101

100102
// set_<field>() and set_<repeated_field>(i)
101103
template <int kFieldNum>
102-
static void OnSet(const MessageLite* msg, const void* field) {}
104+
static void OnSet(const MessageLite* /*msg*/, const void* /*field*/) {}
103105

104106
// <repeated_field>_size()
105107
template <int kFieldNum>
106-
static void OnSize(const MessageLite* msg, const void* field) {}
108+
static void OnSize(const MessageLite* /*msg*/, const void* /*field*/) {}
107109

108110
// unknown_fields()
109-
static void OnUnknownFields(const MessageLite* msg) {}
111+
static void OnUnknownFields(const MessageLite* /*msg*/) {}
110112

111113
// mutable_unknown_fields()
112-
static void OnMutableUnknownFields(const MessageLite* msg) {}
114+
static void OnMutableUnknownFields(const MessageLite* /*msg*/) {}
113115

114-
static void OnHasExtension(const MessageLite* msg, int extension_tag,
115-
const void* field) {}
116+
static void OnHasExtension(const MessageLite* /*msg*/, int /*extension_tag*/,
117+
const void* /*field*/) {}
116118
// TODO: Support clear in the proto compiler.
117-
static void OnClearExtension(const MessageLite* msg, int extension_tag,
118-
const void* field) {}
119-
static void OnExtensionSize(const MessageLite* msg, int extension_tag,
120-
const void* field) {}
121-
static void OnGetExtension(const MessageLite* msg, int extension_tag,
122-
const void* field) {}
123-
static void OnMutableExtension(const MessageLite* msg, int extension_tag,
124-
const void* field) {}
125-
static void OnSetExtension(const MessageLite* msg, int extension_tag,
126-
const void* field) {}
127-
static void OnReleaseExtension(const MessageLite* msg, int extension_tag,
128-
const void* field) {}
129-
static void OnAddExtension(const MessageLite* msg, int extension_tag,
130-
const void* field) {}
131-
static void OnAddMutableExtension(const MessageLite* msg, int extension_tag,
132-
const void* field) {}
133-
static void OnListExtension(const MessageLite* msg, int extension_tag,
134-
const void* field) {}
135-
static void OnMutableListExtension(const MessageLite* msg, int extension_tag,
136-
const void* field) {}
119+
static void OnClearExtension(const MessageLite* /*msg*/,
120+
int /*extension_tag*/, const void* /*field*/) {}
121+
static void OnExtensionSize(const MessageLite* /*msg*/, int /*extension_tag*/,
122+
const void* /*field*/) {}
123+
static void OnGetExtension(const MessageLite* /*msg*/, int /*extension_tag*/,
124+
const void* /*field*/) {}
125+
static void OnMutableExtension(const MessageLite* /*msg*/,
126+
int /*extension_tag*/, const void* /*field*/) {
127+
}
128+
static void OnSetExtension(const MessageLite* /*msg*/, int /*extension_tag*/,
129+
const void* /*field*/) {}
130+
static void OnReleaseExtension(const MessageLite* /*msg*/,
131+
int /*extension_tag*/, const void* /*field*/) {
132+
}
133+
static void OnAddExtension(const MessageLite* /*msg*/, int /*extension_tag*/,
134+
const void* /*field*/) {}
135+
static void OnAddMutableExtension(const MessageLite* /*msg*/,
136+
int /*extension_tag*/,
137+
const void* /*field*/) {}
138+
static void OnListExtension(const MessageLite* /*msg*/, int /*extension_tag*/,
139+
const void* /*field*/) {}
140+
static void OnMutableListExtension(const MessageLite* /*msg*/,
141+
int /*extension_tag*/,
142+
const void* /*field*/) {}
137143
};
138144

139145
} // namespace protobuf

0 commit comments

Comments
 (0)